From owner-svn-src-user@FreeBSD.ORG  Sun Apr 25 04:04:23 2010
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1BBB9106564A;
	Sun, 25 Apr 2010 04:04:23 +0000 (UTC)
	(envelope-from jmallett@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 0BC208FC19;
	Sun, 25 Apr 2010 04:04:23 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o3P44M6U039688;
	Sun, 25 Apr 2010 04:04:22 GMT
	(envelope-from jmallett@svn.freebsd.org)
Received: (from jmallett@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o3P44MOD039686;
	Sun, 25 Apr 2010 04:04:22 GMT
	(envelope-from jmallett@svn.freebsd.org)
Message-Id: <201004250404.o3P44MOD039686@svn.freebsd.org>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Sun, 25 Apr 2010 04:04:22 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r207184 - user/jmallett/octeon/sys/mips/cavium/octe
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2010 04:04:23 -0000

Author: jmallett
Date: Sun Apr 25 04:04:22 2010
New Revision: 207184
URL: http://svn.freebsd.org/changeset/base/207184

Log:
  Add a note to my future self.

Modified:
  user/jmallett/octeon/sys/mips/cavium/octe/octe.c

Modified: user/jmallett/octeon/sys/mips/cavium/octe/octe.c
==============================================================================
--- user/jmallett/octeon/sys/mips/cavium/octe/octe.c	Sun Apr 25 04:03:45 2010	(r207183)
+++ user/jmallett/octeon/sys/mips/cavium/octe/octe.c	Sun Apr 25 04:04:22 2010	(r207184)
@@ -32,6 +32,10 @@
  * XXX This file should be moved to if_octe.c
  * XXX The driver may have sufficient locking but we need locking to protect
  *     the interfaces presented here, right?
+ * XXX There is a common MII bus on Octeon, we get the identifier of our PHY
+ *     in priv->phy_id; right now we attach all the PHYs to each interface,
+ *     which is clearly wrong.  Need to either modify miibus or probe and
+ *     attach the specific PHY for each interface without an miibus in between.
  */
 
 #include <sys/param.h>