From nobody Tue Mar 10 19:10:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fVk4D3PT4z6Tt9B for ; Tue, 10 Mar 2026 19:10:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fVk4D1SJYz45P0 for ; Tue, 10 Mar 2026 19:10:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773169852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DGvGj0PQsARdbj1G0pzaWP+hBafSY+MdwT3hGWgMXf4=; b=o4R7dTFvdg+QG+G26lin6lBds4BDQ2OzrmSufgVJYIb+GZ1+FTL69a7d92inOFZLd6bvzH 3IjmnDUjiuqO2NCBa0+yMmOKqHYbdK859szQHxLCtmfTS0z8JWBAfckiJJjtoKGb3yNA2U /ov3EBm2yYErL8SGEpXVCPJZF0uvClsDZ9gk6SaX1snI8/ffTUS+YjEmu+41wSZ7ujlt2o 7A72/YqhmDmxouc8sc1ll6FFKBDzT/ZFCUAc9f4PPTnqMtgtLGA1K1F2f/OxmX719O57zz ZpVTqHi4gBNhNRJmWXkv36ReVWdm4uJjiBTFUTe+MKCQMdGLMttQUv6iVOvgCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773169852; a=rsa-sha256; cv=none; b=UuNstdc7pADFPRcTlfQ3h7uww4xpWj+f/bTSZNYI1PpdqiyL0luEH4Alj4kY6JQbmgqQtQ l3TZVQz6TKxglZXkaJsvJHc/CCeLip1yUtnlNLYy0K4zEOEgo4Y+rdn0/ydA0RE5NoWSfs pq04A5JeIJR8iu0mD9norC6nb4VeRe2fiqS2bCmY3kqBe217MWoUo1rsc9tZ9GqsR2PrIQ f6UyHrncl6+uDIF6x6zPOBSnmqJ3yNZq1EyRI9lBVV0L526ZHRAHtd+fCb8MTUY6Lokpr1 ZMK93Qz+8rZ9fRFB8AjDuMLsWGOLWAchtQfyZ8cSlFgcXyDEIj5BLveNhAqNRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773169852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DGvGj0PQsARdbj1G0pzaWP+hBafSY+MdwT3hGWgMXf4=; b=BhDAibPzSG5GHpopYGABXqYC15jbIrTlY4/TAp7n31NsGR5JjPbNPH5r9k/asOg10Ac1ny XgCZYuMunQw1pPMhr6oxdW+3ACxecm+H7Enm3JYwNJ6Csmkf69Sp0jZ4XujFDiyH1VJrL9 qzCxioi2f9sht5wRKZE4+Cv899Nw4RPDI4joYC72zkdSfb2lm/0sjNdmkPT2C8zlxSnYdl XFdXG3sjzJvLLlCgpbQC7tI2YA5voUlLSG5I9RiEWWWIPCmHVe8gF0q9dvkQGjicDsRBEi p3sSbT4UH+VqQGEcknEMRWTzIw/MPocJiqtwBwY/5pQGJPQ2OqMhQf1O73eJ9g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fVk4D0kywz9Hj for ; Tue, 10 Mar 2026 19:10:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 244f4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Mar 2026 19:10:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Sarah Walker From: Andrew Turner Subject: git: 1a92fc9c1210 - main - virtio: Restore mb() calls List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1a92fc9c1210f9c99a19fda5a86682a78d39872f Auto-Submitted: auto-generated Date: Tue, 10 Mar 2026 19:10:52 +0000 Message-Id: <69b06cbc.244f4.657b42c@gitrepo.freebsd.org> The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=1a92fc9c1210f9c99a19fda5a86682a78d39872f commit 1a92fc9c1210f9c99a19fda5a86682a78d39872f Author: Sarah Walker AuthorDate: 2026-03-10 19:08:38 +0000 Commit: Andrew Turner CommitDate: 2026-03-10 19:10:21 +0000 virtio: Restore mb() calls Until an issue seen on amd64 can be investigated restore two mb() calls to virtio. Reviewed by: andrew Fixes: c499ad6f997c ("virtio: Use bus_dma for ring and indirect buffer allocations") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D55766 --- sys/dev/virtio/virtqueue.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c index dbd55e02e091..b7fdb4703ccb 100644 --- a/sys/dev/virtio/virtqueue.c +++ b/sys/dev/virtio/virtqueue.c @@ -565,6 +565,9 @@ virtqueue_notify(struct virtqueue *vq) /* Ensure updated avail->idx is visible to host. */ bus_dmamap_sync(vq->vq_ring_dmat, vq->vq_ring_mapp, BUS_DMASYNC_PREWRITE); +#if defined(__i386__) || defined(__amd64__) + mb(); +#endif if (vq_ring_must_notify_host(vq)) vq_ring_notify_host(vq); @@ -960,6 +963,9 @@ vq_ring_enable_interrupt(struct virtqueue *vq, uint16_t ndesc) bus_dmamap_sync(vq->vq_ring_dmat, vq->vq_ring_mapp, BUS_DMASYNC_PREWRITE); +#if defined(__i386__) || defined(__amd64__) + mb(); +#endif /* * Enough items may have already been consumed to meet our threshold