Date: Sat, 10 May 2003 10:26:09 -0700 From: David Schultz <das@FreeBSD.ORG> To: John Baldwin <jhb@FreeBSD.ORG> Cc: arch@FreeBSD.ORG Subject: Re: [Bikeshed] sigacts locking Message-ID: <20030510172609.GA29039@HAL9000.homeunix.com> In-Reply-To: <XFMail.20030509175046.jhb@FreeBSD.org> References: <XFMail.20030509175046.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 09, 2003, John Baldwin wrote: > As part of the locking for the proc structure, I needed to lock > the procsig and sigacts stuctures so that kill(), killpg(), > sigaction() and a few other system calls can be pulled out from > under Giant. After talking with Peter some, I decided to > pull the sigacts structure out of the u-area and merge it with > the procsig structure under the sigacts name. I then added a > mutex to each sigacts and added locking where appropriate. With > this change, the aforementioned system calls are now MP safe > along with sendsig(), *signal(), cursig(), etc. The patch for > all this is at http://www.FreeBSD.org/~jhb/patches/sigacts.patch > I would appreciate comments, review, etc. that people may have. > If all goes well I hope to get this into 5.1. Thanks. It occurs to me that this leaves very little in the uarea. You have a struct pstats, which is less than 256 bytes, and you have the kinfo_proc, which shouldn't need to be there anyway. Perhaps now would also be a good time to get rid of uarea swapping and the associated complexity altogether.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030510172609.GA29039>