From owner-p4-projects Sun Dec 22 19:10:18 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id E751037B406; Sun, 22 Dec 2002 19:10:15 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D63937B401 for ; Sun, 22 Dec 2002 19:10:15 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA2F543EEA for ; Sun, 22 Dec 2002 19:10:14 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id gBN3ACuB072696; Sun, 22 Dec 2002 20:10:13 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 22 Dec 2002 20:09:21 -0700 (MST) Message-Id: <20021222.200921.66023382.imp@bsdimp.com> To: marcel@xcllnt.net Cc: perforce@freebsd.org Subject: Re: PERFORCE change 22623 for review From: "M. Warner Losh" In-Reply-To: <20021222231958.GA1414@athlon.pn.xcllnt.net> References: <200212221912.gBMJCf5i009504@repoman.freebsd.org> <20021222.150927.83284721.imp@bsdimp.com> <20021222231958.GA1414@athlon.pn.xcllnt.net> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20021222231958.GA1414@athlon.pn.xcllnt.net> Marcel Moolenaar writes: : On Sun, Dec 22, 2002 at 03:09:27PM -0700, M. Warner Losh wrote: : > In message: <200212221912.gBMJCf5i009504@repoman.freebsd.org> : > Marcel Moolenaar writes: : > : Convert to the new sioprobe/sioattach interface. While here, : > : remove the sio_pci_unit_kludge function. We consider this the : > : "future" version which according to the comment makes it : > : obsolete :-) : > : > It is not obsolete. There's no way to say that the ISA serial ports : > have reserved sio0 and sio1 so that the pci serial port should attach : > to sio2 or sio4. Until there is, this kludge is needed. : : Can you tell me why or when this would be useful? Yes. Consider that we probe sio on isa after sio on pci. When probing sio on pci, we get sio0 because the sio on isa stuff hasn't happened yet. So, pci steal sio0 and the sio on the isa bus get sio1 and sio2. When using a serial console, this can cause problems with the console code because sio0 is flagged as the conosle, but sio1 is attached and there were (are?) problems in the console code that caused a panic if you ran in this combo. If that's no longer the case, then we have the 'usual' disconnect between the hints and the actual instances. I just remeber when I did it that it was a big deal to me and to the folks that hired me to create a pci driver for the controller based modems. Maybe things have changed, and if so I'm cool with things going away. But if they haven't changed, this needs to stay around until the underlying problems are fixed. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message