Date: Fri, 6 Jun 2008 02:09:27 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: Rui Paulo <rpaulo@FreeBSD.org> Cc: kib@FreeBSD.org, current@FreeBSD.org Subject: Re: cpuctl(formely devcpu) patch test request Message-ID: <20080606020927.8d6675e1.stas@FreeBSD.org> In-Reply-To: <20080605204823.GA7361@epsilon.local> References: <20080605231705.db589d89.stas@FreeBSD.org> <20080605204823.GA7361@epsilon.local>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Fri__6_Jun_2008_02_09_27_+0400_/HeAP5=ja3dyVky6 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, 5 Jun 2008 21:55:39 +0100 Rui Paulo <rpaulo@FreeBSD.org> mentioned: > A couple comments: > 1) Do you plan to MFC this ? For what older versions of FreeBSD will devc= pu be > shipped? In fact, I plan to MFC that to all supported FreeBSD versions (6, 7), as changes are minimal. Until that those versions will be supported by sysutils/devcpu port. >=20 > 2) in cpuctl_modevent(): perhaps it's better to return ENOMEM instead of > ENOSYS if malloc() fails and ENXIO instead of ENOSYS if MSR functionality= is > not present I fully agree on ENOMEM (thanks for noticing that), while I think that returning ENOSYS for MSR-less systems is more correct, as it states that required functionality isn't implemented for this hardware. =20 > 3) I don't mean to impose, but this code needs some small style cleanup, > namely: characters above the 80 column, second level indents are four > spaces" Good catch! Fixed. The updated patch is available at http://www.springdaemons.com/stas/cpuctl.2.diff --=20 Stanislav Sedov ST4096-RIPE --Signature=_Fri__6_Jun_2008_02_09_27_+0400_/HeAP5=ja3dyVky6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkhIZBcACgkQK/VZk+smlYGAAwCeJaDzR/rTaHR5CKT3ASEVI0oB wpwAoIJRjxz21vbtRh61NLZkcOcLY/Rt =cXz9 -----END PGP SIGNATURE----- --Signature=_Fri__6_Jun_2008_02_09_27_+0400_/HeAP5=ja3dyVky6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080606020927.8d6675e1.stas>