From owner-freebsd-testing@FreeBSD.ORG  Wed Apr  2 17:54:36 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id F2BCC8E0
 for <freebsd-testing@freebsd.org>; Wed,  2 Apr 2014 17:54:36 +0000 (UTC)
Received: from relay01.pair.com (relay01.pair.com [209.68.5.15])
 by mx1.freebsd.org (Postfix) with SMTP id 90193170
 for <freebsd-testing@freebsd.org>; Wed,  2 Apr 2014 17:54:36 +0000 (UTC)
Received: (qmail 62918 invoked from network); 2 Apr 2014 17:54:35 -0000
Received: from 87.58.146.155 (HELO x2.osted.lan) (87.58.146.155)
 by relay01.pair.com with SMTP; 2 Apr 2014 17:54:35 -0000
X-pair-Authenticated: 87.58.146.155
Received: from x2.osted.lan (localhost [127.0.0.1])
 by x2.osted.lan (8.14.5/8.14.5) with ESMTP id s32HsYaq075416;
 Wed, 2 Apr 2014 19:54:34 +0200 (CEST)
 (envelope-from pho@x2.osted.lan)
Received: (from pho@localhost)
 by x2.osted.lan (8.14.5/8.14.5/Submit) id s32HsY0v075415;
 Wed, 2 Apr 2014 19:54:34 +0200 (CEST) (envelope-from pho)
Date: Wed, 2 Apr 2014 19:54:34 +0200
From: Peter Holm <peter@holm.cc>
To: Craig Rodrigues <rodrigc@freebsd.org>
Subject: Re: ATF work
Message-ID: <20140402175434.GA75279@x2.osted.lan>
References: <20140402085349.GA61802@x2.osted.lan>
 <CAOtMX2gGn5NMpvSR0FF=z70cUCDn=vTQvVWo2mXk8t9UrNKzuA@mail.gmail.com>
 <CAG=rPVep6wrby4cej0fWSNtYrRhHLn5eOjDsNWWTYv0RpjDqUw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG=rPVep6wrby4cej0fWSNtYrRhHLn5eOjDsNWWTYv0RpjDqUw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Apr 2014 17:54:37 -0000

On Wed, Apr 02, 2014 at 10:21:26AM -0700, Craig Rodrigues wrote:
> On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers <asomers@freebsd.org> wrote:
> > On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm <peter@holm.cc> wrote:
> >> I have uploaded a snapshot of the ATF work done for EMC Isilon,
> >> based primarily on Garrett Cooper's work.
> >>
> >> http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz
> >> +
> >> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr
> >
> > Holy patch queue, Batman!  There's fifty thousand lines of code in here!
> 
> 
> When a patch is that big, it becomes very difficult to review.
> 
> You might want to consider forking a copy on github of the
> https://github.com/freebsd/freebsd repository and maintaining the patch there
> until it is MFC'd:
> 
> https://help.github.com/articles/fork-a-repo
> https://help.github.com/articles/syncing-a-fork
> 
> It's not perfect but some of the web interface tools around the github
> ecosystem make reviewing patches (and contributing updates) a bit easier.
> 

Thank you for the references. I will definitely look at this.
-- 
Peter