From owner-svn-src-all@FreeBSD.ORG Tue Oct 11 23:13:37 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD03D106566B; Tue, 11 Oct 2011 23:13:37 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7544A8FC13; Tue, 11 Oct 2011 23:13:37 +0000 (UTC) Received: by qadz30 with SMTP id z30so131126qad.13 for ; Tue, 11 Oct 2011 16:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=mKg4HMATV5oxq5Iq2vGoq3ADv1av/FvFSh/xWjPNC64=; b=pa7/TfiGOwPg2cp5yRt8PCX/SpdM19GLSmEdjWNw2vGYKfI480vCDfTn2a/Qs7sWd5 +7Po5D7dzyIhbOLAQNYw8fTzft0N3nRBNXmzx5celjJ3Pvnb+RygfH/sTJke/VG/1nVh RRbtk55oGs8IgPKwL/nySEPuTwwEN5n/NRcj8= MIME-Version: 1.0 Received: by 10.224.206.132 with SMTP id fu4mr7889439qab.20.1318374816635; Tue, 11 Oct 2011 16:13:36 -0700 (PDT) Received: by 10.224.74.82 with HTTP; Tue, 11 Oct 2011 16:13:36 -0700 (PDT) In-Reply-To: <86sjmzruo1.fsf@ds4.des.no> References: <201110081247.p98Cl06s063337@svn.freebsd.org> <86sjmzruo1.fsf@ds4.des.no> Date: Tue, 11 Oct 2011 16:13:36 -0700 Message-ID: From: Garrett Cooper To: =?ISO-8859-1?Q?Dag=2DErling_Sm=F8rgrav?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226157 - head/usr.bin/kdump X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2011 23:13:38 -0000 2011/10/11 Dag-Erling Sm=F8rgrav : > Garrett Cooper writes: >> Seeing that you've committed quite a bit to kdump recently, could >> you please take a look at >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D161478 ? > > Hmm, did you run across this while testing your patch? > > % make > cc -O2 -pipe =A0-I/usr/src/usr.bin/kdump/../ktrace -I/usr/src/usr.bin/kdu= mp -I/usr/src/usr.bin/kdump/../.. -I. -g -std=3Dgnu99 -fstack-protector -Ws= ystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstri= ct-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qua= l -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-= subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definiti= on -Wno-pointer-sign -c ioctl.c > cc1: warnings being treated as errors > In file included from ioctl.c:80: > /usr/include/netinet/ip_fil.h:1284: warning: redundant redeclaration of '= bcopywrap' > /usr/include/netinet/ip_compat.h:1543: warning: previous declaration of '= bcopywrap' was here > *** Error code 1 > > Stop in /usr/src/usr.bin/kdump. > > I don't understand why it complains, since both declarations are > identical, modulo whitespace: > > % grep -r bcopywrap /usr/include/netinet > /usr/include/netinet/ip_fil.h:extern =A0 =A0 =A0 =A0 int =A0bcopywrap __P= ((void *, void *, size_t)); > /usr/include/netinet/ip_compat.h:# define =A0 =A0COPYIN(a,b,c) =A0bcopywr= ap((a), (b), (c)) > /usr/include/netinet/ip_compat.h:# define =A0 =A0COPYOUT(a,b,c) bcopywrap= ((a), (b), (c)) > /usr/include/netinet/ip_compat.h:extern =A0 =A0 =A0int =A0 =A0 =A0 =A0 = =A0 =A0bcopywrap __P((void *, void *, size_t)); > % make DEBUG_FLAGS=3D"-g -save-temps" > [...] > % grep bcopywrap /usr/obj/usr/src/usr.bin/kdump/ioctl.i > extern int bcopywrap (void *, void *, size_t); > extern int bcopywrap (void *, void *, size_t); > > BTW, the extern keyword is completely pointless, since it is implicit > for functions. I didn't run into that particular issue, but then again.. it looks like it hasn't been generating my files properly (which seems like a Makefile bug because all of the generated files should be cleaned with make clean). -Garrett