From owner-svn-ports-all@freebsd.org Sun Sep 1 22:48:46 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C4145C8D4B; Sun, 1 Sep 2019 22:48:46 +0000 (UTC) (envelope-from ultima@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M7g24pdmz3xTG; Sun, 1 Sep 2019 22:48:46 +0000 (UTC) (envelope-from ultima@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 845708A45; Sun, 1 Sep 2019 22:48:46 +0000 (UTC) (envelope-from ultima@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x81Mmku8034523; Sun, 1 Sep 2019 22:48:46 GMT (envelope-from ultima@FreeBSD.org) Received: (from ultima@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x81MmkOA034522; Sun, 1 Sep 2019 22:48:46 GMT (envelope-from ultima@FreeBSD.org) Message-Id: <201909012248.x81MmkOA034522@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ultima set sender to ultima@FreeBSD.org using -f From: Richard Gallamore Date: Sun, 1 Sep 2019 22:48:46 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r510747 - head/www/libevhtp X-SVN-Group: ports-head X-SVN-Commit-Author: ultima X-SVN-Commit-Paths: head/www/libevhtp X-SVN-Commit-Revision: 510747 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 22:48:46 -0000 Author: ultima Date: Sun Sep 1 22:48:46 2019 New Revision: 510747 URL: https://svnweb.freebsd.org/changeset/ports/510747 Log: Fix stack overflow that can occur in libevhtp libevhtp allocates a stack based on data length when C99 is detected at compile time. There are no checks to verify that the stack is big enough which can cause a stack overflow. Adding EVHTP_HAS_C99=false at compile time changes this behavior by allocate to a buffer which has proper checks in place. More information about this bug can be found at: https://github.com/criticalstack/libevhtp/issues/118 https://github.com/haiwen/seafile/issues/1928 MFH: 2019Q3 Modified: head/www/libevhtp/Makefile Modified: head/www/libevhtp/Makefile ============================================================================== --- head/www/libevhtp/Makefile Sun Sep 1 21:48:44 2019 (r510746) +++ head/www/libevhtp/Makefile Sun Sep 1 22:48:46 2019 (r510747) @@ -2,7 +2,7 @@ PORTNAME= libevhtp PORTVERSION= 1.2.16 -PORTREVISION= 3 +PORTREVISION= 4 CATEGORIES= www MAINTAINER= ultima@FreeBSD.org @@ -19,7 +19,8 @@ USE_GITHUB= yes GH_ACCOUNT= criticalstack CMAKE_ARGS= -DCMAKE_INCLUDE_PATH:PATH=include/event2 \ - -DCMAKE_LIBRARY_PATH:PATH=lib/event2 + -DCMAKE_LIBRARY_PATH:PATH=lib/event2 \ + -DEVHTP_HAS_C99:BOOL=FALSE PLIST_SUB= PORTVERSION=${PORTVERSION}