From owner-freebsd-ppc@FreeBSD.ORG  Wed May 30 20:37:06 2012
Return-Path: <owner-freebsd-ppc@FreeBSD.ORG>
Delivered-To: powerpc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 715BE1065674;
	Wed, 30 May 2012 20:37:06 +0000 (UTC)
	(envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 390778FC19;
	Wed, 30 May 2012 20:37:06 +0000 (UTC)
Received: from sa-nc-apg-49.static.jnpr.net (natint3.juniper.net
	[66.129.224.36]) (authenticated bits=0)
	by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q4UKap7N045535
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Wed, 30 May 2012 13:36:59 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <0362C399-CB54-451E-A879-E836EF13CE72@semihalf.com>
Date: Wed, 30 May 2012 13:36:46 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <251AF144-587C-4854-88B2-0CD7D26E1DF1@xcllnt.net>
References: <0362C399-CB54-451E-A879-E836EF13CE72@semihalf.com>
To: Rafal Jaworowski <raj@semihalf.com>
X-Mailer: Apple Mail (2.1278)
Cc: powerpc@freebsd.org, Zbyszek Bodek <zbb@semihalf.com>,
	=?utf-8?Q?Piotr_Zi=C4=99cik?= <kosmo@semihalf.com>
Subject: Re: RFC: OpenPIC IPI patch
X-BeenThere: freebsd-ppc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the PowerPC <freebsd-ppc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ppc>
List-Post: <mailto:freebsd-ppc@freebsd.org>
List-Help: <mailto:freebsd-ppc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 May 2012 20:37:06 -0000


On May 30, 2012, at 1:13 PM, Rafal Jaworowski wrote:

> Can you please have a look at this patch and let us know about any =
comments / objections? We identified a problem with IPI on the recent =
FSL eOpenPIC, description in the patch:
>=20
> http://people.freebsd.org/~raj/patches/powerpc/openpic.diff

Looks good. Please consider adding some checks to openpic_ipi() where
we peek into the cpuset_t type and access the "bits". An assert would
be nice if the set contains cpus number 32 or up. This to make it
painfully obvious that it's time to extend openpic_ipi() to handle more
than 32 CPUs if and when the need arises.

FYI,

--=20
Marcel Moolenaar
marcel@xcllnt.net