From owner-cvs-src@FreeBSD.ORG  Thu Oct  6 11:44:51 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 672AE16A41F;
	Thu,  6 Oct 2005 11:44:51 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4C8DA43D72;
	Thu,  6 Oct 2005 11:44:44 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by cyrus.watson.org (Postfix) with ESMTP id 3289246BBA;
	Thu,  6 Oct 2005 07:44:44 -0400 (EDT)
Date: Thu, 6 Oct 2005 12:44:44 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Mike Silbersack <silby@silby.com>
In-Reply-To: <20051006063636.S29769@odysseus.silby.com>
Message-ID: <20051006124123.Y87201@fledge.watson.org>
References: <200510061028.j96ASVoL031977@repoman.freebsd.org>
	<20051006063636.S29769@odysseus.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/tools/tools/netrate/httpd httpd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2005 11:44:51 -0000

On Thu, 6 Oct 2005, Mike Silbersack wrote:

>>  Modified files:
>>    tools/tools/netrate/httpd httpd.c
>>  Log:
>>  Improve realism of benchmark httpd: return some HTTP headers as part
>>  of the sendfile() system call.
>> 
>>  Revision  Changes    Path
>>  1.2       +24 -1     src/tools/tools/netrate/httpd/httpd.c
>
> You can't use this to compare to 4.x then, FWIW.  4.x's sendfile always 
> puts the headers in a separate packet, so in a large percentage of cases 
> it's noticeably less efficient, network-traffic wise.

It depends what you're trying to benchmark.  If the goal is to illustrate 
the performance changes as a result of on-going development, it's 
legitimate to say that the changes in sendfile() are simply part of that 
process.  I.e., it's not cheating to have sendfile() improvements count 
towards overall performance when evaluating overall performance.

Robert N M Watson