From owner-freebsd-net@FreeBSD.ORG Sat Oct 8 00:07:04 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB564106566B; Sat, 8 Oct 2011 00:07:04 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 303CC8FC08; Sat, 8 Oct 2011 00:07:03 +0000 (UTC) Received: by wwe3 with SMTP id 3so6325059wwe.31 for ; Fri, 07 Oct 2011 17:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=x/m+FIzGs04t+i+uKesgrnCb+usM8Nf2c07nHV1Jpc8=; b=QR/zcwETw53ktC0T9Ig55+V6HXpC7Y19KsnzuMJx4h8ahGWtFGkqDtLIGXJAxZg5dz YXfIIxgq7h0qcvWsyPborA3V6Ze8L4tZv7hWxskt2ZeUyurISgdlUFoM/FKrtU5xu5Jl loeJ/jgRT84jVVK4qUt9pkONZrosk0n9JV6BM= Received: by 10.216.143.222 with SMTP id l72mr3174688wej.46.1318032423113; Fri, 07 Oct 2011 17:07:03 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id l9sm18807378wba.5.2011.10.07.17.06.59 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Oct 2011 17:07:02 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 07 Oct 2011 17:05:03 -0700 From: YongHyeon PYUN Date: Fri, 7 Oct 2011 17:05:03 -0700 To: David Christensen Message-ID: <20111008000503.GG11808@michelle.cdnetworks.com> References: <1317315666.2777.8.camel@hitfishpass-lx.corp.yahoo.com> <1317952651.9892.19.camel@hitfishpass-lx.corp.yahoo.com> <1318004610.27029.1.camel@hitfishpass-lx.corp.yahoo.com> <20111007175137.GA11808@michelle.cdnetworks.com> <5D267A3F22FD854F8F48B3D2B523819385F35B561B@IRVEXCHCCR01.corp.ad.broadcom.com> <20111007224359.GF11808@michelle.cdnetworks.com> <5D267A3F22FD854F8F48B3D2B523819385F35B56AF@IRVEXCHCCR01.corp.ad.broadcom.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Bu8it7iiRSEf40bY" Content-Disposition: inline In-Reply-To: <5D267A3F22FD854F8F48B3D2B523819385F35B56AF@IRVEXCHCCR01.corp.ad.broadcom.com> User-Agent: Mutt/1.4.2.3i Cc: "freebsd-net@freebsd.org" , Sean Bruno , Pyun YongHyeon Subject: Re: bce(4) with IPMI [puzzling and puzzling] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2011 00:07:05 -0000 --Bu8it7iiRSEf40bY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 07, 2011 at 04:25:56PM -0700, David Christensen wrote: > > > That's a typo then, 5709 and 5716 share the same ASIC ID. > > > > > > > Thanks for confirmation. > > Could you review the attached patch? > > Looks good. ASIC ID matches my Dell R210 system: > > bce0: mem 0xda000000-0xdbffffff irq 16 at device 0.0 on pci2 > miibus0: on bce0 > bce0: Ethernet address: b8:ac:6f:87:95:f1 > bce0: ASIC (0x57092008); Rev (C0); Bus (PCIe x4, 2.5Gbps); B/C (5.2.2); Bufs (RX:2;TX:2;PG:8); Flags (SPLT|MSI|MFW); MFW (NCSI 2.0.8) > Thanks for testing. Committed with r226123. I also noticed that bce(4) may support BCM5716S because brgphy(4) already supports BCM5709S. Can you test attached patch on BCM5716S? > Dave > > --Bu8it7iiRSEf40bY Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="bce.5716S.diff" Index: sys/dev/bce/if_bce.c =================================================================== --- sys/dev/bce/if_bce.c (revision 226123) +++ sys/dev/bce/if_bce.c (working copy) @@ -154,6 +154,10 @@ { BRCM_VENDORID, BRCM_DEVICEID_BCM5716, PCI_ANY_ID, PCI_ANY_ID, "Broadcom NetXtreme II BCM5716 1000Base-T" }, + /* BCM5716S controllers and OEM boards. */ + { BRCM_VENDORID, BRCM_DEVICEID_BCM5716S, PCI_ANY_ID, PCI_ANY_ID, + "Broadcom NetXtreme II BCM5716S 1000Base-SX" }, + { 0, 0, 0, 0, NULL } }; Index: sys/dev/bce/if_bcereg.h =================================================================== --- sys/dev/bce/if_bcereg.h (revision 226123) +++ sys/dev/bce/if_bcereg.h (working copy) @@ -565,6 +565,7 @@ #define BRCM_DEVICEID_BCM5709 0x1639 #define BRCM_DEVICEID_BCM5709S 0x163A #define BRCM_DEVICEID_BCM5716 0x163B +#define BRCM_DEVICEID_BCM5716S 0x163C #define HP_VENDORID 0x103C --Bu8it7iiRSEf40bY--