From owner-svn-src-head@freebsd.org Wed Feb 26 15:38:36 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F16FE25BAAF; Wed, 26 Feb 2020 15:38:36 +0000 (UTC) (envelope-from pawel.biernacki@gmail.com) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SKhW3R85z42tx; Wed, 26 Feb 2020 15:38:35 +0000 (UTC) (envelope-from pawel.biernacki@gmail.com) Received: by mail-ed1-f48.google.com with SMTP id e10so4258932edv.9; Wed, 26 Feb 2020 07:38:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=CgCuk8k6Uw+2a81JBPsNlo3JjWqHy6mnEFgaWHpLwBs=; b=XBDwPqFac8sDrmK3UAjksJ0eXgAcP65IJ1ZMmC0ApQzLLJbuVY1cNwBQ/xhcGCDAWh G6mAFqEo6oFDs+Z8k2DSnH/n1df81/DvbaC7A3nMEc1ZrSng+aqAZQG3uPsmvrdfBgvi vFtOdxcwgyGHsXDNPBOSxhyIE0pcnvMxnunSKHYjIDMFftsruvUzX/IH1loosoKyLW83 v+imqntcRw+0PkasumCkCQLMQn3vkKaq4tPis+3FrcqVdjKNiljSXNM/4t4sjtF+UBLi AH3qOHGEtGD8K5hYjFh5pkZbdZo8TPxNJ2qv0o51veBhIofTBITtOPXrt74bEalP3BhQ PSUQ== X-Gm-Message-State: APjAAAWxSOOoYfvc5uEX0QTK9BJwus0AVC2AyoKzV/yIOstlarDqxCFh ifG0rnkPRdcrGRecmQmfJvS+PXlR X-Google-Smtp-Source: APXvYqyzNTps15P2c5kDmjATFMm+VGh7rCghmtD4j+pTEWm77BpOAytPv0tck1z3ftxmRp8bCfNvRA== X-Received: by 2002:ac2:5b08:: with SMTP id v8mr2881844lfn.92.1582730000677; Wed, 26 Feb 2020 07:13:20 -0800 (PST) Received: from macbook.localdomain (193-106-244-222.noc.fibertech.net.pl. [193.106.244.222]) by smtp.gmail.com with ESMTPSA id g78sm1187512lfd.21.2020.02.26.07.13.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Feb 2020 07:13:19 -0800 (PST) From: =?utf-8?Q?Pawe=C5=82_Biernacki?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: svn commit: r358334 - head/sys/sys Date: Wed, 26 Feb 2020 16:13:17 +0100 References: <202002261512.01QFCdnZ017432@repo.freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <202002261512.01QFCdnZ017432@repo.freebsd.org> Message-Id: X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 48SKhW3R85z42tx X-Spamd-Bar: +++++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pawelbiernacki@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=pawelbiernacki@gmail.com X-Spamd-Result: default: False [5.08 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; MV_CASE(0.50)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FORGED_SENDER(0.30)[kaktus@FreeBSD.org,pawelbiernacki@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[kaktus@FreeBSD.org,pawelbiernacki@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(5.00)[222.244.106.193.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.4]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_SPAM_MEDIUM(0.55)[0.547,0]; BAD_REP_POLICIES(0.10)[]; IP_SCORE(-2.17)[ip: (-6.12), ipnet: 209.85.128.0/17(-2.99), asn: 15169(-1.67), country: US(-0.05)]; NEURAL_SPAM_LONG(0.90)[0.904,0]; RCVD_IN_DNSWL_NONE(0.00)[48.208.85.209.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_POSSIBLE(0.00)[48.208.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 15:38:37 -0000 Approved by: kib (mentor, blanket) > On 26 Feb 2020, at 16:12, Pawel Biernacki wrote: >=20 > Author: kaktus > Date: Wed Feb 26 15:12:38 2020 > New Revision: 358334 > URL: https://svnweb.freebsd.org/changeset/base/358334 >=20 > Log: > Move the SYSCTL_ENFORCE_FLAGS to SYSCTL_NODE_WITH_LABEL where it = should be > at the beginning. >=20 > Modified: > head/sys/sys/sysctl.h >=20 > Modified: head/sys/sys/sysctl.h > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/sys/sysctl.h Wed Feb 26 14:26:36 2020 = (r358333) > +++ head/sys/sys/sysctl.h Wed Feb 26 15:12:38 2020 = (r358334) > @@ -324,7 +324,6 @@ TAILQ_HEAD(sysctl_ctx_list, sysctl_ctx_entry); > SYSCTL_OID_RAW(sysctl___##name, &sysctl__children, \ > nbr, #name, CTLTYPE_NODE|(access), NULL, 0, \ > handler, "N", descr, NULL); \ > - SYSCTL_ENFORCE_FLAGS(access); \ > CTASSERT(((access) & CTLTYPE) =3D=3D 0 || = \ > ((access) & SYSCTL_CT_ASSERT_MASK) =3D=3D CTLTYPE_NODE) >=20 > @@ -335,6 +334,7 @@ TAILQ_HEAD(sysctl_ctx_list, sysctl_ctx_entry); > #define SYSCTL_NODE_WITH_LABEL(parent, nbr, name, access, = handler, descr, label) \ > SYSCTL_OID_GLOBAL(parent, nbr, name, CTLTYPE_NODE|(access), = \ > NULL, 0, handler, "N", descr, label); = \ > + SYSCTL_ENFORCE_FLAGS(access); = \ > CTASSERT(((access) & CTLTYPE) =3D=3D 0 || = \ > ((access) & SYSCTL_CT_ASSERT_MASK) =3D=3D CTLTYPE_NODE) >=20