From nobody Tue Apr 19 18:35:33 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0144711E16A8; Tue, 19 Apr 2022 18:35:36 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KjXYM6Jb8z4Xh1; Tue, 19 Apr 2022 18:35:35 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ej1-f47.google.com with SMTP id i27so34686831ejd.9; Tue, 19 Apr 2022 11:35:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=ddNoJdBML6xhY8K0D5qzdddTRptYtq+LSAgwwKhBLvQ=; b=1dWk2nrRpkdHCt5ZgVmk8YJCqX1tp0oz9iBjkHKhHF2LCLdlWSIo7DAqAmxnRkXLwc r2RTkwfiebaEdpEWX7ALxwuhh6Rk5O1CaidVdWHmNX/4YG7ukAJehBoVb9kpcRLAlV7T hDyRGfLSwpEq65YAVJ0Gvg1lNwmwWVmUtOW+RlI39MLrn8A+mp1XJfEFiykFDXavAjeb OUg0N8IGfkRsa/+hfAjXRIEtT/+QsbdgNzWGMBRKQKDSSqcz13e9BjCLNI3VC87fBrHG zmCfiZk4LH565hI17dI7i6ZilWbf4TpVGzXUJkJReF+ME5fuI+VSt9wqxNs7KZuNYN1w +3rw== X-Gm-Message-State: AOAM532sKzqRAWF4yDg1v5rd43IUueMc4I++e8tmNhYrtMgOaj0tNHsx TJE892vxZv+7bE8zF0MRq3sPgVsGez5HEw== X-Google-Smtp-Source: ABdhPJwB+0e234/jdGFfGCnfJQLXCl+hXlJ2h2BzpL5HkPjXVAL9bmNMYkMHYao73WaAv45HvD0yIg== X-Received: by 2002:a17:906:2bc5:b0:6cd:e676:3624 with SMTP id n5-20020a1709062bc500b006cde6763624mr14522735ejg.277.1650393328619; Tue, 19 Apr 2022 11:35:28 -0700 (PDT) Received: from [192.168.0.193] (dynamic-089-204-138-164.89.204.138.pool.telefonica.de. [89.204.138.164]) by smtp.gmail.com with ESMTPSA id k7-20020a17090666c700b006e8688d5fcbsm5933717ejp.135.2022.04.19.11.35.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 11:35:28 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 20:35:33 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Alan Somers Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202204191256.23JCunGk043900@gitrepo.freebsd.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: Re: git: 8c47d8f53854 - main - prometheus_sysctl_exporter: fix metric aliasing In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4KjXYM6Jb8z4Xh1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 19/04/2022 16:33, Alan Somers wrote: > On Tue, Apr 19, 2022 at 8:22 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: >> On 19/04/2022 14:56, Alan Somers wrote: >>> The branch main has been updated by asomers: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=8c47d8f53854825d8e8591ccd06e32b2c798f81c >>> >>> commit 8c47d8f53854825d8e8591ccd06e32b2c798f81c >>> Author: Alan Somers >>> AuthorDate: 2022-04-18 21:29:37 +0000 >>> Commit: Alan Somers >>> CommitDate: 2022-04-19 12:56:39 +0000 >>> >>> prometheus_sysctl_exporter: fix metric aliasing >>> >>> When exporting sysctls to Prometheus, the exporter replaces "." with >>> "_". This caused several metrics to alias, confusing the Prometheus >>> server. Fix it by: >>> >>> * Renaming the "tcp_log_bucket" UMA zone to "tcp_log_id_bucket". Also, >>> rename "tcp_log_node" to "tcp_log_id_node" for consistency. >>> >>> * Not exporting sysctls with "(LEGACY)" in the description. That is >>> used by ZFS sysctls that have been replaced by others, many of which >>> alias to the same Prometheus metric name (like "vfs.zfs.arc_max" and >>> "vfs.zfs.arc.max"). >>> >>> PR: 259607 >>> Reported by: delphij >>> MFC after: 2 weeks >>> Sponsored by: Axcient >>> Reviewed by: delphij,rew,thj >>> Differential Revision: https://reviews.freebsd.org/D34952 >> This should definitely make it to release notes. >> >> Also, should we keep a log of these kind of changes in the history section of the manual pages? I >> find the history logs that systemd folks publish in their manual pages to be quite informative, >> e.g., https://www.man7.org/linux/man-pages//man7/systemd.net-naming-scheme.7.html > Do you think that the uma zone rename is too disruptive to MFC? I don't know :) I don't know how often this sysctl is used and how often it is consumed by automation. I think that it's alright to perform such clean-ups, especially for such a new tool like our in-base prometheus exporter. My point is that due to the nature of prometheus metrics, I think it is a good idea to give users a heads-up that the metric name is going to change. A note in the release notes should be sufficient. Best, Mateusz Piotrowski