From nobody Sun Dec 3 11:56:12 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sjld305xSz52mLK; Sun, 3 Dec 2023 11:56:23 +0000 (UTC) (envelope-from meta@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sjld26jpkz4GmM; Sun, 3 Dec 2023 11:56:22 +0000 (UTC) (envelope-from meta@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701604582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e0OIWjUJIC9pEgxTRlGYRBopk5JG6qkZfoHgzbTlmNo=; b=MNNIZG86CJZMMvAvat6H++OxVL4cdY66Di6OAekYvaxgXBr0l7KJ83AH9Xv4LXC8j5rgNF jw330iwpBS4k+ISBoXzqC1R1Em8936STzTt9cp+3LAhX2aHZYaxFRcZmAULOdDTInDoD1B pY/2jFZPaoIs0cwZr3VpzR7fhsPG6QoSvSqqchqVx+0ZHjifYxj1RGmZ9pEA94jaab4rZw ewcpxnp9wbQ8M4LpU/pZAnRqgujp5zNsRHCQttI2CyPsoNWET4mKLv707JcUlaWDdIQpss 9Yu8CbFleE4HG9u7qeObWLHqr3sZXjy83VQl9ke621Try2ZqfdYEpEMVgh3cfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701604582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e0OIWjUJIC9pEgxTRlGYRBopk5JG6qkZfoHgzbTlmNo=; b=T+W2L3FsI4vDSsKi3fQSFdOZHGmQ0fddZsIYYi4JYuXUwDDae0TpnSbQnJBwTeu6NOGxLZ bk1P6yfy8nTHgqH4KIKIP2/dXM4vYcNT7xSxxcFdtvN61UDDpAs3KjDeXA+jVCqXyX2AKm e66N9XjkAeU43yaiM7d+1aErcn9JLQhAgKe6xgASIDSqsPTbEP6JMemFD4g9evN2E8QfEV PSozMu8xFg0w2qOKedEn6Ib5+I47pn2LrsAwqHsq5sSTExb6QEvbPcsBYiiuCxh1Uzzgjq hZoG10NeNV2bcdHLXA2wSH0UXwrflYwnVvI7largzcGqgSQ76/7NQPRkz+xPqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701604582; a=rsa-sha256; cv=none; b=l04Nly0uGOoOvo5SRD7GIAtecC1Eji06xYP5xIkKLphYxXUL14MiuUTpQl2LpAhYHL1jh/ hB0V7VPSIGo7Jz/ZMgebn492J4VXfpmSrcgvLkUzMqfYna2tewmpMNzMVUf02CqFVL1Nar VeWP36UHUdY7bYGrL2uiZrlV2ZVXpSaUag4AfJyIleT1nf2Z8S21U6OxKmfQtydQsts+XQ CjtHLmJJZpw3U2KHPYm/S4mX+zFfeZKlE/7KXSEDbie+g/TikH+ddzH4XLIWT5xYi1o0ol NsMXYyYCCwWMoszYKQK6c46OYGQyiXtUgI3BGXiR5CNOOAh3yQyx3iMAR8cjKg== Received: from icepick.vmeta.jp (unknown [IPv6:2403:bd80:c100:401:f0cd:261b:2136:730b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Sjld01Tk8zBty; Sun, 3 Dec 2023 11:56:19 +0000 (UTC) (envelope-from meta@freebsd.org) Date: Sun, 3 Dec 2023 20:56:12 +0900 From: Koichiro Iwao To: Jochen Neumeister Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org, "portmgr@FreeBSD.org" Subject: Re: git: 8848573087ff - 2023Q4 - www/nginx: fix build with a third-party passenger module Message-ID: X-Operating-System: FreeBSD 14.0-STABLE amd64 References: <202312030958.3B39wDQA036372@gitrepo.freebsd.org> <8ce4f3ab-54d2-422c-96d3-9b2094fa6099@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8ce4f3ab-54d2-422c-96d3-9b2094fa6099@FreeBSD.org> As I already mentioned on Bugzilla, it's my totally fault I misunderstood the date I submitted a patch to bugzilla. I was looking into 2 PRs concurrently so I god them mixed up. I'm sorry about that. I believe tested build fixes are covered under blanket approval. Correct me if I misunderstood. On Sun, Dec 03, 2023 at 11:01:26AM +0100, Jochen Neumeister wrote: > Is it normal that you just do something like that here without consulting > anyone? What do we have rules for here? > > > Am 03.12.23 um 10:58 schrieb Koichiro Iwao: > > The branch 2023Q4 has been updated by meta: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=8848573087ff210c5383adcd899b055c50467fb4 > > > > commit 8848573087ff210c5383adcd899b055c50467fb4 > > Author: Jochen Neumeister > > AuthorDate: 2023-12-03 07:51:41 +0000 > > Commit: Koichiro Iwao > > CommitDate: 2023-12-03 09:57:04 +0000 > > > > www/nginx: fix build with a third-party passenger module > > PR: 275161 > > Sponsored by: Netzkommune GmbH > > This commit is required to complete PR 275161. The fix for > > www/nginx-devel is not necessary at the moment. > > (cherry picked from commit b31426d1f77c12e47a60ff4b6b663826afd4702f) > > --- > > www/nginx/Makefile | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/www/nginx/Makefile b/www/nginx/Makefile > > index be56e8b593c4..d037ba99710a 100644 > > --- a/www/nginx/Makefile > > +++ b/www/nginx/Makefile > > @@ -1,6 +1,6 @@ > > PORTNAME= nginx > > PORTVERSION= 1.24.0 > > -PORTREVISION?= 12 > > +PORTREVISION?= 13 > > PORTEPOCH= 3 > > CATEGORIES= www > > MASTER_SITES= https://nginx.org/download/ \ > > @@ -240,6 +240,10 @@ CONFIGURE_ENV+= OPTIMIZE="yes" > > CFLAGS+= -DNDEBUG > > .endif > > +.if ${PORT_OPTIONS:MPASSENGER} > > +CONFIGURE_ENV+= EXTRA_PRE_CXXFLAGS="-std=c++14" > > +.endif > > + > > # Fix build failure on clang >= 12 > > .if ${PORT_OPTIONS:MHTTP_PERL} && ${OSVERSION} >= 1301000 > > CFLAGS+= -Wno-compound-token-split-by-macro -- meta