Date: Sat, 12 Feb 2000 22:00:02 -0800 (PST) From: TATEOKA Takamichi <tate@cs.uec.ac.jp> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/13691: tcpslice problems Message-ID: <200002130600.WAA03369@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/13691; it has been noted by GNATS. From: TATEOKA Takamichi <tate@cs.uec.ac.jp> To: bmah@CA.Sandia.GOV Cc: freebsd-gnats-submit@freebsd.org Subject: Re: bin/13691: tcpslice problems Date: Sun, 13 Feb 2000 14:39:45 +0900 Hi, From: bmah@CA.Sandia.GOV (Bruce A. Mah) > B. Apply the patch attached here, to replace all of the fseek/ftell > calls with fsetpos/fgetpos calls. Another way to do this is to > replace fseek/ftell with fseeko/ftello. The patch from Vern (cited by > Sheldon) replaces two of the ftell calls with ftello, but doesn't > touch any of the fseek calls. > > (My patch uses fsetpos/fgetpos because that's what I was familiar with > at the time. Using fseeko/ftello may in fact be better because it > involves fewer code changes.) I think your patch is good enough to work on FreeBSD box and fixes known problems of tcpslice. I think that It is better to use fseeko/ftello instead of fsetpos/fgetpos. Because it makes type mismatch for offset value. In fact, both of them are off_t in most case, however, it's not guaranteed. (see definition of fpos_t in /usr/include/stdio.h.) -- Takamichi TATEOKA (tate@cs.uec.ac.jp) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200002130600.WAA03369>