From owner-freebsd-usb@FreeBSD.ORG  Sat Mar 11 11:45:08 2006
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
X-Original-To: freebsd-usb@freebsd.org
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D136D16A41F
	for <freebsd-usb@freebsd.org>; Sat, 11 Mar 2006 11:45:08 +0000 (GMT)
	(envelope-from morten@oslonett.no)
Received: from mail47.e.nsc.no (mail47.e.nsc.no [193.213.115.47])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 493CD43D49
	for <freebsd-usb@freebsd.org>; Sat, 11 Mar 2006 11:45:05 +0000 (GMT)
	(envelope-from morten@oslonett.no)
Received: from [10.10.10.7] (ti211310a080-10183.bb.online.no [85.166.39.199])
	by mail47.nsc.no (8.13.5/8.13.5) with ESMTP id k2BBj3VF022466
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Sat, 11 Mar 2006 12:45:04 +0100 (CET)
Message-ID: <4412B83F.1080100@oslonett.no>
Date: Sat, 11 Mar 2006 12:45:03 +0100
From: Morten Johansen <morten@oslonett.no>
User-Agent: Thunderbird 1.5 (X11/20060213)
MIME-Version: 1.0
To: Nenad Kljajic <nenad.k@yubc.net>
X-Enigmail-Version: 0.94.0.0
Content-Type: multipart/mixed; boundary="------------000707040307060709070702"
Cc: freebsd-usb@freebsd.org
Subject: [PATCH] Logitech USB Receiver mouse workaround patch
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Mar 2006 11:45:08 -0000

This is a multi-part message in MIME format.
--------------000707040307060709070702
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit

Nenad Kljajic wrote:
> There is some problem with hid_report_size() function
> and Logitech USB receiver in /usr/src/sys/dev/usb/ums.c.
> The returned value is 14 but it should be 8.
> This results in subsamling mouse data and jerky cursor movement.
>
> I have tested this workaround patch for
> Logitech® Cordless Desktop® MX™ 3100
> and it works fine now.
>   

Can you try the attached patch to hid.c instead the workaround?
There is also an open PR usb/77604 on this.


--------------000707040307060709070702
Content-Type: text/plain;
 name="hid.c.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="hid.c.patch"

--- hid.c	Sat Jun  4 18:00:09 2005
+++ hid.c.mj	Tue Feb 22 02:32:55 2005
@@ -371,14 +371,22 @@
 {
 	struct hid_data *d;
 	struct hid_item h;
-	int size, id;
+	int hi, lo, size, id;
 
 	id = 0;
+	hi = lo = -1;
 	for (d = hid_start_parse(buf, len, 1<<k); hid_get_item(d, &h); )
-		if (h.report_ID != 0 && !id)
-			id = h.report_ID;
+		if (h.kind == k) {
+			if (h.report_ID != 0 && !id)
+				id = h.report_ID;
+			if (h.report_ID == id) {
+				if (lo < 0)
+					lo = h.loc.pos;
+				hi = h.loc.pos + h.loc.size * h.loc.count;
+			}
+		}
 	hid_end_parse(d);
-	size = h.loc.pos;
+	size = hi - lo;
 	if (id != 0) {
 		size += 8;
 		*idp = id;	/* XXX wrong */

--------------000707040307060709070702--