From owner-cvs-src@FreeBSD.ORG  Sat Oct 14 07:25:19 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 277A616A4CE;
	Sat, 14 Oct 2006 07:25:19 +0000 (UTC) (envelope-from bde@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B834343D53;
	Sat, 14 Oct 2006 07:25:17 +0000 (GMT) (envelope-from bde@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9E7PCqU008455;
	Sat, 14 Oct 2006 07:25:12 GMT (envelope-from bde@repoman.freebsd.org)
Received: (from bde@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9E7PC37008454;
	Sat, 14 Oct 2006 07:25:12 GMT (envelope-from bde)
Message-Id: <200610140725.k9E7PC37008454@repoman.freebsd.org>
From: Bruce Evans <bde@FreeBSD.org>
Date: Sat, 14 Oct 2006 07:25:12 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/nfsclient nfs_vnops.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Oct 2006 07:25:19 -0000

bde         2006-10-14 07:25:12 UTC

  FreeBSD src repository

  Modified files:
    sys/nfsclient        nfs_vnops.c 
  Log:
  Don't do null Setattr RPCs for VA_MARK_ATIME.  When we added the
  VA_MARK_ATIME feature to fix POSIX conformance fore execve() and mmap(),
  we thought that it was optimized well enough for the one file system
  that supports it (ffs) and harmless for other file systems (except
  layered ones which already get the layering for VOP_SETATTR() wrong).
  However, nfs_setattr() doesn't do much parameter checking, so when
  it gets a combination of parameters that it doesn't understand, it
  always does a Setattr RPC.  This RPC can't do anything good, and for
  VA_MARK_ATIME it is null except for wasting a lot of time.
  
  This is the smallest and easiest to fix of several bugs that have
  increased the number of RPCs for kernel builds on nfs by more than
  100% since 2004-11-05.  The real-time increase depends on network
  latency and parallelization and can also be very large (approaching
  the same percentage for unparallelized operations like "make depend"
  on systems with fast CPUs and high-latency networks).
  
  Revision  Changes    Path
  1.270     +2 -2      src/sys/nfsclient/nfs_vnops.c