From owner-svn-src-head@freebsd.org Tue Aug 2 14:55:04 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55677BACFD7; Tue, 2 Aug 2016 14:55:04 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from mail.madpilot.net (grunt.madpilot.net [78.47.145.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 174971C12; Tue, 2 Aug 2016 14:55:03 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from mail (mail [192.168.254.3]) by mail.madpilot.net (Postfix) with ESMTP id 3s3fPd4wTzzZrR; Tue, 2 Aug 2016 16:55:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= content-transfer-encoding:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:from:from :references:subject:subject:received:received; s=mail; t= 1470149699; x=1471964100; bh=+nGnlChNcxOaI64i9cfzNH55KSmQwILCQCG ORPIAy18=; b=hk8asQLCIBhFkN2qOmowd7aDcjpJOozJG9tTrmvINRDCXIxE4A1 Hn1pa88bJkQR65ubQo++Mnh2HsdNfeoMB6XTYpVm4L8LZf+erhR5OYXEB+CSHV4C IOsw/4QzC8A2Rk2ynt9wghpDmRa7QXPpGvftuoW3o3IxC7UCSQ/xL5yM= Received: from mail.madpilot.net ([192.168.254.3]) by mail (mail.madpilot.net [192.168.254.3]) (amavisd-new, port 10024) with ESMTP id 2w9Om8ovk565; Tue, 2 Aug 2016 16:54:59 +0200 (CEST) Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206]) by mail.madpilot.net (Postfix) with ESMTPSA; Tue, 2 Aug 2016 16:54:59 +0200 (CEST) Subject: Re: svn commit: r303047 - head/usr.bin/sed To: Alexey Dokuchaev , "Pedro F. Giffuni" References: <201607192256.u6JMuewv007503@repo.freebsd.org> <20160802141738.GA84154@FreeBSD.org> Cc: svn-src-head@freebsd.org, Mikhail Teterin , svn-src-all@freebsd.org, src-committers@freebsd.org From: Guido Falsi Message-ID: <51d8013e-bc4b-a511-306d-0e362a8c3e86@madpilot.net> Date: Tue, 2 Aug 2016 16:54:59 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160802141738.GA84154@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2016 14:55:04 -0000 On 08/02/16 16:17, Alexey Dokuchaev wrote: > On Tue, Jul 19, 2016 at 10:56:40PM +0000, Pedro F. Giffuni wrote: >> New Revision: 303047 >> URL: https://svnweb.freebsd.org/changeset/base/303047 >> >> Log: >> sed(1): Assorted cleanups and simplifications. >> >> Const-ify several variables, make it build cleanly with WARNS level 5. >> >> Submitted by: mi >> PR: 195929 >> MFC after: 1 month > > Hi Pedro, > > This change causes `games/openttd' to fail now, because the generated > `$wrkdir/openttd-1.6.1/objs/release/Makefile' file is broken (SRCS var > is set to bogus value, search for ^SRCS). Reverting usr.bin/sed back > to r303046 fixes it. > > The latest revision (with ngie@'s fix) exhibits the same problem. > > Now the port uses somewhat obscure build system, but the sed(1) magic > happens inside generate_foo() functions using SRC_REPLACE variable set > in make_sed() inside `config.lib' file; these functions are called by > the configure script. > > Would you or Mikhail mind taking a look? Thanks, By chance I had a look at this, thinking it was a local problem on my machine, and noticed that the substitutions get truncated at exactly 5120 characters. Looks like some hardcoded 5KiB buffer. -- Guido Falsi