From owner-svn-src-all@FreeBSD.ORG Mon Sep 3 14:41:05 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1740F106566B; Mon, 3 Sep 2012 14:41:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 8A76B8FC16; Mon, 3 Sep 2012 14:41:03 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q83Ef2CQ061691; Mon, 3 Sep 2012 17:41:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q83EeoVs033620; Mon, 3 Sep 2012 17:40:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q83Eeoai033619; Mon, 3 Sep 2012 17:40:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 3 Sep 2012 17:40:50 +0300 From: Konstantin Belousov To: Pedro Giffuni Message-ID: <20120903144050.GN33100@deviant.kiev.zoral.com.ua> References: <20120903073133.GB33100@deviant.kiev.zoral.com.ua> <1346681599.92069.YahooMailClassic@web113502.mail.gq1.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BfpcaheOxHyW4lRg" Content-Disposition: inline In-Reply-To: <1346681599.92069.YahooMailClassic@web113502.mail.gq1.yahoo.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240060 - in head: include/rpc sys/rpc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2012 14:41:05 -0000 --BfpcaheOxHyW4lRg Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 03, 2012 at 07:13:19AM -0700, Pedro Giffuni wrote: > Hello, >=20 > Sorry for the brevity but I can inly anser on a mobile device > right now ... >=20 > --- Lun 3/9/12, Konstantin Belousov ha scritto: >=20 > > Da: Konstantin Belousov > > Oggetto: Re: svn commit: r240060 - in head: include/rpc sys/rpc > > A: "Pedro F. Giffuni" > > Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@f= reebsd.org > > Data: Luned? 3 settembre 2012, 02:31 > > On Sun, Sep 02, 2012 at 09:04:40PM > > +0000, Pedro F. Giffuni wrote: > > > Author: pfg > > > Date: Sun Sep=9A 2 21:04:40 2012 > > > New Revision: 240060 > > > URL: http://svn.freebsd.org/changeset/base/240060 > > >=20 > > > Log: > > >=9A=9A=9AFix RPC headers for C++ > > >=9A=9A=9A > > >=9A=9A=9AC++ mangling will cause trouble with > > variables like __rpc_xdr > > >=9A=9A=9Ain xdr.h so rename this to XDR. > > Which troubles ? > > > =20 > PR 137443 =46rom the PR, I fail to see what is the problem in our headers, and why the issue is not in some third-party C++ code. It is definitely has nothing to do with C++ name mangling. >=20 > > Although not very useful due to many other namespace > > pollution problems > > in the rpc headers, __rpc_xdr is in the > > implementation-reserved namespace, > > while XDR is not. > >=20 >=20 > The forced reference here is {Open}Solaris: >=20 > http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/rpc/xd= r.h >=20 > OpenGrok found no reference to __rpc_xdr > in OpenSolaris/illumos. I see, Solaris does typedef struct XDR { ... } XDR; and we now use the same trick. So my objections, if any, were against the commit message and not the actual code change then. Thanks. --BfpcaheOxHyW4lRg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBEwXIACgkQC3+MBN1Mb4j61gCgiweJgcQqiX2TBPu+ZTFXHF6b K00AoNQWrqMSIQWySdAC2Vbb0x1LDuuv =xCph -----END PGP SIGNATURE----- --BfpcaheOxHyW4lRg--