From owner-freebsd-stable@FreeBSD.ORG Fri Apr 27 21:37:35 2007 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B1A5F16A400 for ; Fri, 27 Apr 2007 21:37:35 +0000 (UTC) (envelope-from rmarella@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.227]) by mx1.freebsd.org (Postfix) with ESMTP id 4DEEE13C480 for ; Fri, 27 Apr 2007 21:37:35 +0000 (UTC) (envelope-from rmarella@gmail.com) Received: by nz-out-0506.google.com with SMTP id s1so583565nze for ; Fri, 27 Apr 2007 14:37:34 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding; b=Scg/BI7FeMQt9tAmVwHqQmQkxgOJbnNtfZoY5an2VEVyJds42x7vyKGsbrqFKEXSeOPnT78FR+ZluxVSn9xsPuqMGZ5VHsssoDAQK3esTgvfr/6k1ZWaw9+drCJedOqlVyRJDBS3FjhjKHQSaXdI0qoggQSthqBV2yC0Mex++Bw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding; b=retB3fExoGx0eF5uIAekX4ziORXSEyvKd1M58/mH7WFo+l2fFoVLbTVvNavwE8ugERc1WV0ieJZoyz70IKOa7/xIRXYRfXsjSSPpXF7yuWF24HfXg1ZSYB3vMaf3TqWneJfMFBM3tapgNExoiyhrIV1fdtzMnNh1RTYFiti9vAE= Received: by 10.65.157.10 with SMTP id j10mr7346136qbo.1177708413143; Fri, 27 Apr 2007 14:13:33 -0700 (PDT) Received: from p4 ( [66.75.108.47]) by mx.google.com with ESMTP id c1sm4724049nzd.2007.04.27.14.13.29; Fri, 27 Apr 2007 14:13:30 -0700 (PDT) Date: Fri, 27 Apr 2007 11:13:26 -1000 From: Robert Marella To: Scott Long Message-ID: <20070427111326.0bc4c581@p4> In-Reply-To: <46325CDE.2010904@samsco.org> References: <20070427150134.64D3713C448@mx1.freebsd.org> <20070427153218.GA9091@melamine.cuivre.fr.eu.org> <20070427174922.GA5655@zone3000.net> <46324CCF.7040109@samsco.org> <20070427193119.GA95165@melamine.cuivre.fr.eu.org> <46325CDE.2010904@samsco.org> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.11; i386-portbld-freebsd6.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-stable@FreeBSD.ORG, Thomas Quinot Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2007 21:37:35 -0000 On Fri, 27 Apr 2007 14:28:14 -0600 Scott Long wrote: > Thomas Quinot wrote: > > * Scott Long, 2007-04-27 : > > > >> Oh hell, I know exactly what the problem is! The opcode for a > >> TEST_UNIT_READY is 0x00. This is probably the command that is > >> generating the CHECK_CONDITION. The test for saved_cmd is entirely > >> bogus. > > > > Hmmmm. Looks like a very plausible culprit. Good catch Scott! > > (I felt there had to be something wrong when I wrote that test, > > incidentally, precisely because of TEST_UNIT_READY). > > > > Nikolay, Ganbold, (and others), here's another patch against > > 1.42.2.3, please let me know if it works for you. > > > > Thomas. > > > > Index: atapi-cam.c > > =================================================================== > > RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v > > retrieving revision 1.50 > > diff -u -r1.50 atapi-cam.c > > --- atapi-cam.c 14 Mar 2007 01:59:00 -0000 1.50 > > +++ atapi-cam.c 27 Apr 2007 19:26:09 -0000 > > @@ -729,7 +743,7 @@ > > * issued a REQUEST SENSE automatically and that > > operation > > * returned without error. > > */ > > - if (request->u.atapi.saved_cmd != 0 && > > request->error == 0) { > > + if (request->u.atapi.sense.key != 0 && > > request->error == 0) { bcopy (&request->u.atapi.sense, > > &csio->sense_data, sizeof(struct atapi_sense)); csio->ccb_h.status > > |= CAM_AUTOSNS_VALID; } > > Right, just make sure that this isn't filled with garbage before you > send the command. If you're using ata_alloc_request(), and you're not > recycling requests internally, then you should be fine. > > Scott > I just installed this patch on my i386 system and I can now start K3B without the system crashing. I still have this in dmesg when starting the system: acd1: FAILURE - INQUIRY ILLEGAL REQUEST asc=0x24 ascq=0x00 acd0: FAILURE - INQUIRY ILLEGAL REQUEST asc=0x24 ascq=0x00 And this in /var/log/messages each time I start K3B Apr 27 10:47:39 p4 kernel: acd1: FAILURE - MODE_SENSE_BIG ILLEGAL REQUEST asc=0x24 ascq=0x00 Apr 27 10:47:39 p4 last message repeated 3 times Apr 27 10:52:07 p4 kernel: acd1: FAILURE - MODE_SENSE_BIG ILLEGAL REQUEST asc=0x24 ascq=0x00 I successfully burned an audio CD even with the above errors. The patch seems to work. I will try it on my amd64 machine and report if it does not work there. Thank you Robert