From nobody Fri Mar 1 20:20:51 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tmfc562x1z5D0WK for ; Fri, 1 Mar 2024 20:20:53 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-8fa8.mail.infomaniak.ch (smtp-8fa8.mail.infomaniak.ch [83.166.143.168]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tmfc53sJ7z4rXW for ; Fri, 1 Mar 2024 20:20:53 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4Tmfc336fLzMrg28; Fri, 1 Mar 2024 21:20:51 +0100 (CET) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4Tmfc30VXnzMpnPd; Fri, 1 Mar 2024 21:20:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pyret.net; s=20231006; t=1709324451; bh=SIxM4zGPMhj9yARqhDow0QcS07xqQFEUzKyOGul8Syo=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=WlR8Al092LlvX/YSfk1XBZmgcBZGzK/jkYOoZBR4rMHGEfDjpuJoSE7UXAHFt/Xd3 T1cMjc5G2Q9YajDynn2gSxJvteN9e4gN028760xON6OnS9/va12rZEAeYPvVWdCwZL /rFQNcWEx20Z9PRifov4N/BoU3abgc96DHyqm/2M9mn0KoZuoX4sAmLhnbmuFQqW/B o2hwDWba37Li0ZuD/IATnukpbi48G2t8LXEqy70nk/CmRpEKqEW9TRsrGeoc15Sp+C KDGUgfVTL612ekG+ZtnXwZkQz+OcZJNOf13kZyfkPglfivfROVebaGbd471WIDSVK7 JR8KzI1Xw3G8Q== Message-ID: Date: Fri, 01 Mar 2024 21:20:51 +0100 Subject: Re: git: c2afef5c2587 - main - Features/testing.mk: Introduce the TESTING_UNSAFE knob. From: Daniel Engberg Reply-To: Daniel Engberg To: Gleb Popov Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1709324451_c04ed208324fd26229f6468c7211f23b_=_" X-WS-User-Origin: eyJpdiI6InJsWGlKUWxJZnZoMGZhZk1TbDgwUXc9PSIsInZhbHVlIjoicFFPT1VDYkdHd1NrMVl5OWdkSG0zZz09IiwibWFjIjoiNzc4MjM0ZTAxZDZlMjJmZGQwMzg2MzY3MzI4NzlkYzZkNjQ1NjJhMzdmZGNhNTM4Y2JmNTA3ODFhYmZmZWMzZSIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6Im1ndUEyQ1ppVVlhTGtLMnpZaE9aS0E9PSIsInZhbHVlIjoiOTBsVW5PUHpPRFR2Nml0aXZnZkx0UT09IiwibWFjIjoiOWUwZThhZTQxMDQ3YjU1M2VjYTcwZWEyMGQ3ZDY3MWE2MDVhOGUyNDU0Y2U0OWQyZjJkYTlmZTkzYWE4ZGE3NCIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.647) References: <202403011927.421JRqxx065749@gitrepo.freebsd.org> In-Reply-To: <202403011927.421JRqxx065749@gitrepo.freebsd.org> X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:83.166.128.0/19, country:CH] X-Rspamd-Queue-Id: 4Tmfc53sJ7z4rXW --_=_swift_1709324451_c04ed208324fd26229f6468c7211f23b_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-03-01T20:27:52.000+01:00, Gleb Popov wrote:= >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0arrowd: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org= /ports/commit/?id=3Dc2afef5c2587738b16b52def34edcebe4e421905 >=C2=A0 >= =C2=A0commit=C2=A0c2afef5c2587738b16b52def34edcebe4e421905 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Gleb=C2=A0Popov=C2=A0 >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-03-01=C2=A019:25:37= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Gleb= =C2=A0Popov=C2=A0 >=C2=A0 >=C2=A0CommitDate:=C2= =A02024-03-01=C2=A019:26:53=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0Features/testing.mk=C2=A0[http://testing.mk]:=C2=A0Introduce= =C2=A0the=C2=A0TESTING_UNSAFE=C2=A0knob. >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Approved=C2=A0by:= =C2=A0=C2=A0=C2=A0=C2=A0tcberner >=C2=A0 >=C2=A0--- >=C2=A0 >=C2= =A0=C2=A0Mk/Features/testing.mk=C2=A0[http://testing.mk]=C2=A0|=C2=A05= =C2=A0++++- >=C2=A0 >=C2=A0=C2=A01=C2=A0file=C2=A0changed,=C2=A04=C2= =A0insertions(+),=C2=A01=C2=A0deletion(-) >=C2=A0 >=C2=A0diff=C2=A0--gi= t=C2=A0a/Mk/Features/testing.mk=C2=A0[http://testing.mk]=C2=A0b/Mk/Features= /testing.mk=C2=A0[http://testing.mk] >=C2=A0 >=C2=A0index=C2=A015af7e28= eb7c..a266f6effe91=C2=A0100644 >=C2=A0 >=C2=A0---=C2=A0a/Mk/Features/te= sting.mk=C2=A0[http://testing.mk] >=C2=A0 >=C2=A0+++=C2=A0b/Mk/Features= /testing.mk=C2=A0[http://testing.mk] >=C2=A0 >=C2=A0@@=C2=A0-4,12=C2= =A0+4,15=C2=A0@@ >=C2=A0 >=C2=A0=C2=A0#=C2=A0-=C2=A0If=C2=A0set,=C2= =A0and=C2=A0the=C2=A0port=C2=A0supports=C2=A0it,=C2=A0the=C2=A0software's= =C2=A0test=C2=A0suite=C2=A0will=C2=A0be=C2=A0compiled >=C2=A0 >=C2= =A0=C2=A0#=C2=A0=C2=A0=C2=A0and=C2=A0run=C2=A0during=C2=A0the=C2=A0normal= =C2=A0building=C2=A0pipeline=C2=A0between=C2=A0'stage'=C2=A0and=C2=A0'packa= ge' >=C2=A0 >=C2=A0=C2=A0#=C2=A0=C2=A0=C2=A0stages. >=C2=A0 >=C2= =A0+#=C2=A0-=C2=A0A=C2=A0port=C2=A0may=C2=A0define=C2=A0TESTING_UNSAFE=3Dye= s=C2=A0if=C2=A0its=C2=A0tests=C2=A0are=C2=A0known=C2=A0to=C2=A0fail=C2= =A0at=C2=A0the >=C2=A0 >=C2=A0+#=C2=A0=C2=A0=C2=A0moment. >=C2=A0 >= =C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0.if=C2=A0!defined(_TESTING_MK_INCLUDE= D) >=C2=A0 >=C2=A0=C2=A0_TESTING_MK_INCLUDED=3D=C2=A0=C2=A0=C2=A0=C2= =A0yes >=C2=A0 >=C2=A0=C2=A0TESTING_Include_MAINTAINER=3D=C2=A0=C2= =A0=C2=A0=C2=A0portmgr@FreeBSD.org >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >= =C2=A0+.=C2=A0=C2=A0if=C2=A0!defined(TESTING_UNSAFE) >=C2=A0 >=C2=A0= =C2=A0_TESTING_PACKAGE_DEP=3D=C2=A0=C2=A0=C2=A0=C2=A0test >=C2=A0 >= =C2=A0+.=C2=A0=C2=A0endif >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0= =C2=A0.endif >=C2=A0 >=C2=A0- Hi, Thanks for adding this, how= ever this won't work on ports that uses TEST menu option as far as I can = tell which is a relatively common occurence? Se also https://cgit.= freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495 Best regards, = Daniel --_=_swift_1709324451_c04ed208324fd26229f6468c7211f23b_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-03-01T20:27:52.000+01:00, Gleb Popov <arrowd@FreeBSD.org>= ; wrote:
The bra=
nch main has been updated by arrowd:


=

commit c2afef5c2587738b16b52def34edcebe4e421905
Author: =
    Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2024-03-01 19:=
25:37 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-03-01 19:26:53 +0000

 Mk/Features/testing.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

<=
/div>
diff --git a/Mk/Features/testing.mk b/Mk/Features/testing.mk
index 15af7e28eb7c..a266f6effe91 1=
00644
--- a/Mk/Features/testing.mk
+++ b/Mk/Features/testing.mk
@@ -4,12 +4,1=
5 @@
 # - If set, and the port supports it, the software's te=
st suite will be compiled
 #   and run during the normal buil=
ding pipeline between 'stage' and 'package'
 #   stages.
<=
/div>
+# - A port may define TESTING_UNSAFE=3Dyes if its tests are know=
n to fail at the
+#   moment.
 
 =
.if !defined(_TESTING_MK_INCLUDED)
 _TESTING_MK_INCLUDED=3D=
=09yes
 TESTING_Include_MAINTAINER=3D=09portmgr@FreeBSD.org
 
+.  if !defined(TESTING_UNSAFE)
 _TEST=
ING_PACKAGE_DEP=3D=09test
+.  endif
 
=

 .endif
-
Hi,
=

Thanks for adding this, however this won't work o= n ports that uses TEST menu option as far as I can tell which is a relative= ly common occurence?

Best regards,
Daniel

--_=_swift_1709324451_c04ed208324fd26229f6468c7211f23b_=_--