From owner-freebsd-current@freebsd.org Mon Nov 9 13:21:44 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5735462F4B for ; Mon, 9 Nov 2020 13:21:44 +0000 (UTC) (envelope-from mike@sentex.net) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CVBV04Tw8z4pPX for ; Mon, 9 Nov 2020 13:21:44 +0000 (UTC) (envelope-from mike@sentex.net) Received: by mailman.nyi.freebsd.org (Postfix) id 9836D46383B; Mon, 9 Nov 2020 13:21:44 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 97FE6463651 for ; Mon, 9 Nov 2020 13:21:44 +0000 (UTC) (envelope-from mike@sentex.net) Received: from pyroxene2a.sentex.ca (pyroxene19.sentex.ca [IPv6:2607:f3e0:0:3::19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "pyroxene.sentex.ca", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CVBV03hkKz4pdT; Mon, 9 Nov 2020 13:21:44 +0000 (UTC) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:8916:f6b3:b043:ee40] ([IPv6:2607:f3e0:0:4:8916:f6b3:b043:ee40]) by pyroxene2a.sentex.ca (8.15.2/8.15.2) with ESMTPS id 0A9DLhIp030167 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Mon, 9 Nov 2020 08:21:43 -0500 (EST) (envelope-from mike@sentex.net) Subject: Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM)) To: lev@FreeBSD.org, Eric Joyner Cc: current References: <88004d48-4434-875a-5a36-0627b00c2f38@gmail.com> <1906251966.36777.1590562439792.JavaMail.open-xchange@opme11oxm03aub.bagnolet.francetelecom.fr> <997c1389-5e18-b07e-d342-c787c841a4c4@gmail.com> <711876429.20200601003941@serebryakov.spb.ru> <05a17072-570a-6e05-d3e6-802b3bf30e57@sentex.net> <040f0b35-b2bd-34b5-7203-b1d36d99897b@FreeBSD.org> From: mike tancsa Message-ID: <1eae84f7-b137-c7dd-232f-94b49088aa56@sentex.net> Date: Mon, 9 Nov 2020 08:21:43 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <040f0b35-b2bd-34b5-7203-b1d36d99897b@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4CVBV03hkKz4pdT X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2020 13:21:44 -0000 On 11/9/2020 7:32 AM, Lev Serebryakov wrote: > On 07.11.2020 2:46, Eric Joyner wrote: > >> The other issue is that I still don't know which devices need a >> restart / which devices do not, or whether a restart is strictly >> necessary and if there is another way to do this without worrying >> about restarting the device. >  Could this be copied from pre-iflib driver? It did right things > without unneeded resets, including some `em` chips. > >  BTW, I'm surprised, that pre-iflib drivers still available on Intel > site and in ports. And sometimes works better :-( > For my specific case (no DHCLIENT and I210 chipset), I just used --- if_em.c     2020-09-26 07:46:16.474942000 -0400 +++ /tmp/if_em.c        2020-11-09 08:13:55.888378000 -0500 @@ -4047,6 +4047,7 @@  {         switch (event) {         case IFLIB_RESTART_VLAN_CONFIG: +               return (false);         default:                 return (true);         } And that seems to work for my particular chipset and use case.     ---Mike