Date: Mon, 9 Nov 2020 08:21:43 -0500 From: mike tancsa <mike@sentex.net> To: lev@FreeBSD.org, Eric Joyner <erj@freebsd.org> Cc: current <current@freebsd.org> Subject: Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM)) Message-ID: <1eae84f7-b137-c7dd-232f-94b49088aa56@sentex.net> In-Reply-To: <040f0b35-b2bd-34b5-7203-b1d36d99897b@FreeBSD.org> References: <88004d48-4434-875a-5a36-0627b00c2f38@gmail.com> <1906251966.36777.1590562439792.JavaMail.open-xchange@opme11oxm03aub.bagnolet.francetelecom.fr> <997c1389-5e18-b07e-d342-c787c841a4c4@gmail.com> <711876429.20200601003941@serebryakov.spb.ru> <d67b7835-f7de-e230-08df-9d35b75b5b91@sentex.net> <a7d4eb82-29d1-34f7-85df-c6f7ffb83032@sentex.net> <CA%2Bb0zg_PVBnaOBK=Mg9923ciV0gUTZHdhiQ-oVxjJWU_dN8ANQ@mail.gmail.com> <05a17072-570a-6e05-d3e6-802b3bf30e57@sentex.net> <CAKdFRZjeY0QyE4w6D8eD0xBHJ4jX9goo5NqMpb10nFdqUh-e%2BA@mail.gmail.com> <040f0b35-b2bd-34b5-7203-b1d36d99897b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/9/2020 7:32 AM, Lev Serebryakov wrote:
> On 07.11.2020 2:46, Eric Joyner wrote:
>
>> The other issue is that I still don't know which devices need a
>> restart / which devices do not, or whether a restart is strictly
>> necessary and if there is another way to do this without worrying
>> about restarting the device.
> Could this be copied from pre-iflib driver? It did right things
> without unneeded resets, including some `em` chips.
>
> BTW, I'm surprised, that pre-iflib drivers still available on Intel
> site and in ports. And sometimes works better :-(
>
For my specific case (no DHCLIENT and I210 chipset), I just used
--- if_em.c 2020-09-26 07:46:16.474942000 -0400
+++ /tmp/if_em.c 2020-11-09 08:13:55.888378000 -0500
@@ -4047,6 +4047,7 @@
{
switch (event) {
case IFLIB_RESTART_VLAN_CONFIG:
+ return (false);
default:
return (true);
}
And that seems to work for my particular chipset and use case.
---Mike
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1eae84f7-b137-c7dd-232f-94b49088aa56>