From owner-svn-src-all@FreeBSD.ORG  Tue Dec 10 19:30:08 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9A099B23;
 Tue, 10 Dec 2013 19:30:08 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 71377185A;
 Tue, 10 Dec 2013 19:30:08 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4D38EB91E;
 Tue, 10 Dec 2013 14:30:06 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Gleb Smirnoff <glebius@freebsd.org>
Subject: Re: svn commit: r259150 - head/sys/dev/cxgbe
Date: Tue, 10 Dec 2013 14:29:57 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; )
References: <201312100007.rBA074Qq055579@svn.freebsd.org>
 <20131210192650.GK4615@FreeBSD.org>
In-Reply-To: <20131210192650.GK4615@FreeBSD.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201312101429.58025.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 10 Dec 2013 14:30:06 -0500 (EST)
Cc: svn-src-head@freebsd.org, Adrian Chadd <adrian@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2013 19:30:08 -0000

On Tuesday, December 10, 2013 2:26:50 pm Gleb Smirnoff wrote:
> On Tue, Dec 10, 2013 at 12:07:04AM +0000, Adrian Chadd wrote:
> A> Author: adrian
> A> Date: Tue Dec 10 00:07:04 2013
> A> New Revision: 259150
> A> URL: http://svnweb.freebsd.org/changeset/base/259150
> A> 
> A> Log:
> A>   Print out the full PCIe link negotiation during dmesg.
> A>   
> A>   I found this useful when checking whether a NIC is in a PCIE 3.0 8x 
slot
> A>   or not.
> A>   
> A>   Reviewed by:	np
> A>   Sponsored by:	Netflix, inc.
> 
> Shouldn't this be done with common code for all drivers
> on PCI bus(es)?
> 
> This is definitely useful for all devices, not to cxgbe(4) only.

It's already done in pciconf -lc which is the right place to put this instead 
of adding more noise to dmesg.

-- 
John Baldwin