From owner-svn-src-stable@FreeBSD.ORG Tue Jul 31 05:39:08 2012 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5FB75106566B for ; Tue, 31 Jul 2012 05:39:08 +0000 (UTC) (envelope-from fjoe@samodelkin.net) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1E1518FC12 for ; Tue, 31 Jul 2012 05:39:08 +0000 (UTC) Received: by obbun3 with SMTP id un3so12970593obb.13 for ; Mon, 30 Jul 2012 22:39:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:x-originating-ip:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=M00B8Um8C+YCZM5RXHYFkwIhAW5uVVQ9xwsIvcGJa3M=; b=h7eDr1xzYV3xfma7iWH7UzRP45hoW7woFZsNwIz4cq5yvpTDq6dpXz0wpWPBApT+4I lvQg37uFislJtd9xaYl5T+CNWW3q8ANPkGIoeSTeH7QM3pIBKTXPQl6iVCUn9Ovcsd3X ypJhOW61vxSNljh1RVNptbTBSo3lxzzaEH/4Qg5Z4Jh0CCxjk1a/fLrs/oUUtTEBcZJo P8u8bzzOuKbSkcSeZpBXl5w3d3b6b4kD4Egn5r+dd+SPCI+ArJye5uwLz1DZtMwb+M5U rPk2QN3liLiBJ74bA0Ac4uy3EMHE4QvEAbZsZ7FGV54b4misU+QkfPI+Rk8CXRi1Su/H gMaQ== MIME-Version: 1.0 Received: by 10.182.14.36 with SMTP id m4mr21273754obc.71.1343713147693; Mon, 30 Jul 2012 22:39:07 -0700 (PDT) Sender: fjoe@samodelkin.net Received: by 10.182.240.49 with HTTP; Mon, 30 Jul 2012 22:39:07 -0700 (PDT) X-Originating-IP: [93.92.220.179] In-Reply-To: <201207301132.34524.jhb@freebsd.org> References: <201207251742.q6PHgvDj083177@svn.freebsd.org> <201207301132.34524.jhb@freebsd.org> Date: Tue, 31 Jul 2012 12:39:07 +0700 X-Google-Sender-Auth: xRh4sdD3vzeKIMoexCFKE_0ZXoM Message-ID: From: Max Khon To: John Baldwin Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQl0GTAg1B479v8nsBZY9qmL4RgNhtz0DwjAM5pPJn6X7HcAn4ro0qhKkwQ4NYC/dCrLQdr4 Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r238775 - stable/8/sys/dev/puc X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2012 05:39:08 -0000 John, On Mon, Jul 30, 2012 at 10:32 PM, John Baldwin wrote: > On Wednesday, July 25, 2012 1:42:57 pm Max Khon wrote: >> Author: fjoe >> Date: Wed Jul 25 17:42:57 2012 >> New Revision: 238775 >> URL: http://svn.freebsd.org/changeset/base/238775 >> >> Log: >> MFC: r227457, r237350, r237357 >> >> Add support for the following Moxa PCIe multiport serial boards: >> - CP102E >> - CP102EL >> - CP104EL-A >> - CP104JU >> - CP114EL >> - CP118EL-A >> - CP168EL-A > > You ignored the comments from Marcel when you committed this to HEAD it seems. > You need to revert d_ofs back to a int8_t and add a config_function for these > adapters instead that use an offset of 0x200. Well, I did not ignore comments from Marcel - his e-mail got lost in my inbox. Sorry about that. I was notified about the issue off the list several days ago and fixed it today. Max