From nobody Tue Apr 4 11:31:49 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrQZt13Lhz43RKr; Tue, 4 Apr 2023 11:31:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrQZt0KPTz4GC9; Tue, 4 Apr 2023 11:31:50 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680607910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hvAhua2IsQM33BdbkSTQdGwfvXkNzleCvyxP5r435zc=; b=Lh1zLRR+O7qb0KES0XYxU/NbxsBN65olnpaC2jE1S7OoRHnNiVdU/Z9yOUa2xRL9PDortG XRN35Mz4g8lUvMiWk2GpyZd0dS8U99JrFzKShfxl9PgFMRtkbbHTOjAwuj4+5h5mEHC1o1 qOGaIj0MrfH1RAApPSeWicKqPmRKOK3fXyV5DHlMpwiU2xEqfC7+8kcwsWgOver9hO70zB hePm42p7iIuEPi1F4NBsOlqa8L4AjVqC0pC6RXYfyd43ij84CC9d/qcwLrC/TOza2dvMGR KI5DyZJ4NhYJ4R4a282lj8bs992kx937MiwMysh0dKuewEltvKF29Xab5RKylQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680607910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hvAhua2IsQM33BdbkSTQdGwfvXkNzleCvyxP5r435zc=; b=CSiu6rOXGGFdYL/zgcujSeZ7MKPqFG5QPVbke9f/9JZLrF/Jy6nnbh6euEV80x0hrferAB 4ylmck6IUf7LwKIOlotVQ/8PK0vALq9BZufIbjlipPter3kHWkefOO93pF+twEstk8gxbG x/U/08Re9Ewvb0ektXVffoRb2Qc1LTCFvIoEC4+M3M1RdMFPxEAxFI/GNp35eXIKhAhLJn 2PZ8HqXCXY0aBzOQ8uYoevn8aqrwKACPKxr+1gB8Rnx0fD0aEuesyNlnSdnJsA4m687RdH ZFfCM3LWfQPFWLsdgj0cWHvXr6k+XVPztQIlf6E1FSwNrqJUtElgVzm+hxPrpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680607910; a=rsa-sha256; cv=none; b=H2/UGvnrjeWIQAt3kNDc1KW8A6f5S4vWw7DoJL5qxv/O9fOkqVdl2B4E6XSs2/uLMx2FHG R2p4lEa8Fb2jRKXfuhXR7zCYNm9vxtjU7v5h8DLI3mBs4Y00sA35aB/u4bQeaRnMd9uf8p LEXlrMVlJW+xhzgR5rb6LW5yv0y1/xJa2TCzgTAKZx+PnpgxhqCeRvYq0oHfevVUtVmOkV qLfUKCubGjvTJLh9BwukL3yQLfCqDK4HHbl0Bp6QWs0qT1ozUOVUpxlJ29pdIirywDb5kH tDcb0CO8PY1qE1Tvsr+jj/2tJ84GH5FuIpUGFcJ+MHFRztYWHAhEqNi8545ADA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id E6E31167FA; Tue, 4 Apr 2023 11:31:49 +0000 (UTC) Date: Tue, 4 Apr 2023 11:31:49 +0000 From: Alexey Dokuchaev To: Yuri Cc: Mateusz Guzik , Poul-Henning Kamp , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 643336549081 - main - If copy_file_range(2) fails with EXDEV, use fall-back. Message-ID: References: <202304040740.3347eiU8033699@gitrepo.freebsd.org> <202304040959.3349xqqB005509@critter.freebsd.dk> <202304041015.334AF7oF006042@critter.freebsd.dk> <872bff80-a306-a5b8-dbc1-cf54be85fa81@aetern.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <872bff80-a306-a5b8-dbc1-cf54be85fa81@aetern.org> X-ThisMailContainsUnwantedMimeParts: N On Tue, Apr 04, 2023 at 12:31:53PM +0200, Yuri wrote: > Mateusz Guzik wrote: > > On 4/4/23, Poul-Henning Kamp wrote: > >> -------- > >> Alexey Dokuchaev writes: > >> > >>> Okay, but did it leave an empty file, I wonder? > >> > >> I didn't check, but it probably would, because cp(1) must have opened > >> and created the destination in order to call copy_file_range(2). > >> > >> PS: I'll note that EXDEV is not a documented return value from > >> copy_file_range(2), and my surprise that cp(1) did not revert > >> to the fall-back, no matter why copy_file_range(2) failed. > > > > that's a new one and should not be happening, something is borked in > > the kernel -- cross device copies *are* supported > > > > i'll look into it later > > Likely has to do with openzfs merge issues reported by Cy just above? If cp(1) producing empty files for me after commit c98a764c681f is also EXDEV-related (which I'm not sure as of yet), it could be that recent OpenZFS merely exposed an earlier bug (c98a764c681f is from Jan 2 2021). And I didn't have any ZFS on that machine. ./danfe