From owner-freebsd-testing@FreeBSD.ORG Tue Jan 21 20:03:16 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C72B0803; Tue, 21 Jan 2014 20:03:16 +0000 (UTC) Received: from mail-pd0-x22d.google.com (mail-pd0-x22d.google.com [IPv6:2607:f8b0:400e:c02::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 91D95137A; Tue, 21 Jan 2014 20:03:16 +0000 (UTC) Received: by mail-pd0-f173.google.com with SMTP id y10so5082921pdj.32 for ; Tue, 21 Jan 2014 12:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=yzAPJcaYMgNxZ8LlatUinNLcXq3zUnF4UQot0fw+ffA=; b=vMlHmhTv+LANpsPsqcM5RXcZPatwArtm8b07bZ/ensKgvVQ4fy+lBzl1+OCIQ8huDx L2sSwNBlPDdCFmiu1OFZLekgue9iGbnXjx8Y5YwEDw3sUg8FpxoM4y1LkVbtqWoIRA9J Tg1lsXkuHCMSKvi2O3rCIR6qE+YYqWa/w6AbdiW0AViHmKeTJxLqXphOy7gcYS6ffcX7 gIq6secF1QC2X4C9wtngx2N5X7Z/3dUaEu5af9OgsOjGxLd2EcOLuhI6Kwakcai1mNvD MISYLBdl7JZw6GzDiBB7bWvWr7eHwjcN161NaDmGhWvEIyzvGKUDHpWQR2iDtTGROJKx /TPg== X-Received: by 10.68.224.34 with SMTP id qz2mr27328125pbc.84.1390334596151; Tue, 21 Jan 2014 12:03:16 -0800 (PST) Received: from [10.0.2.128] ([64.14.143.130]) by mx.google.com with ESMTPSA id qw8sm14990144pbb.27.2014.01.21.12.03.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Jan 2014 12:03:14 -0800 (PST) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <9EF7C79E-B9D0-4DDE-A425-8D6FFBC0FC1E@gmail.com> X-Mailer: iPhone Mail (11B554a) From: Garrett Cooper Subject: Re: PATCH: fix "WITH_TESTS=yes make installworld" on amd64 Date: Tue, 21 Jan 2014 12:03:08 -0800 To: Alan Somers Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 20:03:16 -0000 > On Jan 21, 2014, at 10:00, Alan Somers wrote: >=20 > I finally found the problem. Make was trying to install tests during > the install32 phase. During this phase, it adds "lib32" to > MAKEOBJDIRPREFIX, so it can't find the tests, which were never built > with that prefix. The command worked fine when I ran it under "make > buildenv", because that uses the normal MAKEOBJDIRPREFIX. >=20 > I'm not sure what prevented the tests from being built during the > lib32 build phase, but this patch will disable tests during both > building and installing 32 bit libraries. >=20 > At work, we never noticed this problem in our SpectraBSD branch > because we set WITHOUT_LIB32=3D1 in /etc/src.conf. >=20 >=20 > Does this patch look ok? Should I be disabling tests some other way? > I looked for a way to disable recursing into the tests directories > whenever LIBRARIES_ONLY was set, but didn't see an easy way. >=20 >=20 > -Alan >=20 >=20 > Index: Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile.inc1 (revision 260986) > +++ Makefile.inc1 (working copy) > @@ -417,7 +417,7 @@ > -DNO_LINT >=20 > LIB32WMAKE=3D ${LIB32WMAKEENV} ${MAKE} ${LIB32WMAKEFLAGS} \ > - -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML > + -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML -DNO_TESTS > LIB32IMAKE=3D ${LIB32WMAKE:NINSTALL=3D*:NDESTDIR=3D*:N_LDSCRIPTROOT=3D*= } -DNO_INCS \ > ${IMAKE_INSTALL} > .endif I have to check my git tree, but I'm pretty sure this was already accoun= ted for (along with some other changes). I'll get back to sometime today about this... Thanks! -Garrett=