From owner-svn-src-head@freebsd.org Tue Jan 7 23:30:46 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 293791F5C08 for ; Tue, 7 Jan 2020 23:30:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47spXN61Qyz3JxN for ; Tue, 7 Jan 2020 23:30:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x829.google.com with SMTP id d18so1248058qtj.10 for ; Tue, 07 Jan 2020 15:30:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BSngzVfvY/agjI1pdvDX420nzK1Dwm8FKf9fIIfbjps=; b=Cwef7ab4X129OarwFy4ynAoABQp3s3rr1tZVD3v4sxsXfhsgd8Nz6/oCw89kUQ5YII MsB56myeKphPVwdOYAnfVuMqTN3jl6bYHM35PRJZlhwS0lehXRdRcv4n3afdpWNKfWxp XwhPvVijcU0cXmm4pQxZbQYghQ4GdSPA8r9eObFMMYcJsoUhxECUG+wxaTNpXcYCW0W8 s9wL2hsNLUmCcW4DcnK44WUQ9JFnaT36HpLTPgOzMxvE2F/Ebys66u5/OaRjyosTK74O 9ETYnTnIHcDIDQg9OZh//nO+MDr118870gqvK4FqSzf2gk7J3pu494XMXnDGZVPFq0TQ GMCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BSngzVfvY/agjI1pdvDX420nzK1Dwm8FKf9fIIfbjps=; b=CBPTkpmz+B3JpP1a9kkOkqcqvxdoCKto5KWeooVaUw121BwGhA4mx4KwuwIFGU8BuA Qgo4vCJIRguZuJza5m1Z7BF9pycfWNMBicC6VYPAjgCjAXAWj7TOjeo4+d8x0s6KtMWY psytA79YOVPNBJ968QHRqpS0utpj+sGUjUrFmIpmFXP2Rfcn0gpQODXeGKVooVveVeVH Wnq2Sehe5QtfdlPL9A8yw43kcOVViqlLej3azPOj56u35/jolQLio5MZKnlbBm3JYtsn Q6tNM8d2mGs+Na+i6zE9FpXCe3lA00xRk6Cq10Xpm7zTxkZZA2jincPf/FP+B4J3JZG3 wFuw== X-Gm-Message-State: APjAAAV8y1Ln9xDSDMx/SbOb6DuHVIasjLgenUkVK5SScyncpRS5/I9q zLfMsWMw1O7pXZ+PfclmhXKXnKqEnl1CLgXs3ilpfg== X-Google-Smtp-Source: APXvYqy0gY2Hom+YRTSDy8oJinKpV9U/lqG/ytFU/shCQbM32/NqWbd9QBs2fmLsYzPf6JjVFmfaZ3jjWpY6AFgLz5U= X-Received: by 2002:ac8:490f:: with SMTP id e15mr1256217qtq.32.1578439843948; Tue, 07 Jan 2020 15:30:43 -0800 (PST) MIME-Version: 1.0 References: <202001072310.007NAdmV011346@repo.freebsd.org> In-Reply-To: <202001072310.007NAdmV011346@repo.freebsd.org> From: Warner Losh Date: Tue, 7 Jan 2020 16:30:32 -0700 Message-ID: Subject: Re: svn commit: r356480 - head/sys/dev/nvme To: Alexander Motin Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47spXN61Qyz3JxN X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Cwef7ab4; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::829) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.66 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[9.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.67)[ip: (-9.30), ipnet: 2607:f8b0::/32(-2.12), asn: 15169(-1.85), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2020 23:30:46 -0000 On Tue, Jan 7, 2020 at 4:10 PM Alexander Motin wrote: > Author: mav > Date: Tue Jan 7 23:10:38 2020 > New Revision: 356480 > URL: https://svnweb.freebsd.org/changeset/base/356480 > > Log: > Increate HMB limit from 1% to 5%. > > SSD capacity in laptops is growing faster then RAM size, so my original > guess seems too low on second thought. Hopefully nobody will build large > array of those crappy SSDs. > If they do, they will likely want to turn off host buffer support anyway, since it uses PCIe bandwidth and large arrays tend to oversubscribe the PCIe bus... Warner > MFC after: 2 weeks > X-MFC-with: 356474 > > Modified: > head/sys/dev/nvme/nvme_ctrlr.c > > Modified: head/sys/dev/nvme/nvme_ctrlr.c > > ============================================================================== > --- head/sys/dev/nvme/nvme_ctrlr.c Tue Jan 7 22:45:02 2020 > (r356479) > +++ head/sys/dev/nvme/nvme_ctrlr.c Tue Jan 7 23:10:38 2020 > (r356480) > @@ -881,8 +881,8 @@ nvme_ctrlr_hmb_alloc(struct nvme_controller *ctrlr) > int err, i; > uint64_t max; > > - /* Limit HMB to 1% of RAM size per device by default. */ > - max = (uint64_t)physmem * PAGE_SIZE / 100; > + /* Limit HMB to 5% of RAM size per device by default. */ > + max = (uint64_t)physmem * PAGE_SIZE / 20; > TUNABLE_UINT64_FETCH("hw.nvme.hmb_max", &max); > > min = (long long unsigned)ctrlr->cdata.hmmin * 4096; >