Date: Mon, 22 Nov 2010 09:05:04 +0100 From: Lars Engels <lars.engels@0x20.net> To: "Carlos A. M. dos Santos" <unixmania@gmail.com> Cc: hackers@freebsd.org, Paul B Mahol <onemda@gmail.com>, Andriy Gapon <avg@freebsd.org> Subject: Re: Remove printf in acpi_tz_sanity() Message-ID: <20101122080504.GD56407@e.0x20.net> In-Reply-To: <AANLkTikymsBGc71QVW4SfoK5pe-uU6XdX7qteMZCQq8Z@mail.gmail.com> References: <AANLkTimThbVyXmgU76m44GTzR0qGAQuJt-9xwunP-QdQ@mail.gmail.com> <4CE98C7E.90301@freebsd.org> <AANLkTimJuq57mzAyb%2BaZ8imrW0cc4qNbZ0FL4_i=3ub9@mail.gmail.com> <AANLkTikymsBGc71QVW4SfoK5pe-uU6XdX7qteMZCQq8Z@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--RGcZ8sFvauoc93XO
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Nov 21, 2010 at 10:18:13PM -0200, Carlos A. M. dos Santos wrote:
> On Sun, Nov 21, 2010 at 9:18 PM, Paul B Mahol <onemda@gmail.com> wrote:
> > On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon <avg@freebsd.org> wrote:
> >> on 21/11/2010 13:07 Paul B Mahol said the following:
> >>> This patch removes printf which spams console whenever thermal state
> >>> is changed in laptop. Source of problem is in buggy BIOS.
> >>>
> >>> diff --git a/sys/dev/acpica/acpi_thermal.c b/sys/dev/acpica/acpi_ther=
mal.c
> >>> index 515a742..00866b2 100644
> >>> --- a/sys/dev/acpica/acpi_thermal.c
> >>> +++ b/sys/dev/acpica/acpi_thermal.c
> >>> @@ -697,11 +697,8 @@ acpi_tz_getparam(struct acpi_tz_softc *sc, char
> >>> *node, int *data)
> >>> =C2=A0static void
> >>> =C2=A0acpi_tz_sanity(struct acpi_tz_softc *sc, int *val, char *what)
> >>> =C2=A0{
> >>> - =C2=A0 =C2=A0if (*val !=3D -1 && (*val < TZ_ZEROC || *val > TZ_ZERO=
C + 2000)) {
> >>> - =C2=A0 =C2=A0 device_printf(sc->tz_dev, "%s value is absurd, ignore=
d (%d.%dC)\n",
> >>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 what=
, TZ_KELVTOC(*val));
> >>> + =C2=A0 =C2=A0if (*val !=3D -1 && (*val < TZ_ZEROC || *val > TZ_ZERO=
C + 2000))
> >>> =C2=A0 =C2=A0 =C2=A0 *val =3D -1;
> >>> - =C2=A0 =C2=A0}
> >>> =C2=A0}
> >>
> >> As is - this is a perfect candidate for a "local only" patch.
> >> To be included into the tree - this, most probably, has to be controll=
ed by a
> >> tunable/sysctl.
> >
> > So solution for useless console spamming is to add useless sysctl.
> >
> > For -1 values, sane default values should be picked up.
> > Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for=
tz0.
> >
> > I'm not first one mentioning this and issue is old several years.
>=20
> +1 (Compaq nx6320)
Yes, almost every HP notebook seems to report -1 every few seconds.
--RGcZ8sFvauoc93XO
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkzqJDAACgkQKc512sD3afgLpwCfUaHov1pFxOKPCD9AfEPsOwLf
ny8An0T9KrnG3iqQfCXxnO36+wzSoIJU
=vVh8
-----END PGP SIGNATURE-----
--RGcZ8sFvauoc93XO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101122080504.GD56407>