From owner-svn-src-all@freebsd.org Tue Apr 9 17:37:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C095B1566B14 for ; Tue, 9 Apr 2019 17:37:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5F5F56FBE4 for ; Tue, 9 Apr 2019 17:37:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x731.google.com with SMTP id n68so10806469qka.1 for ; Tue, 09 Apr 2019 10:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d82o4hPl2rrS2QtT2E3K50s/CbPBkgvsJM++mE8g3f0=; b=P7FHp/89tmBhLUWlo3F7Kf5KIDAsjxqRvgL7bW1hSruShPIjACkd+MnPeiReZFavmA nHQfMwHv46wW4tWAIhWP29sZpatFu5SV3J6ngCNA+yOgtlv7V0xaptVEM+X99P3sGB5h FTBJcWQNudjVDg0tEJVdmL5QmALNGzeCTtW5oVSeJ3LRr051PXNwoyBiPLXA45EQcju5 RaEyk40yQ+SXImIUqiRTSw81JC0b3eSee9cQPgEU+HVzaRYC/RM5oWAY+w/EsZbmmPqm LBds77L/Cm0mZ2+l5OH3t/lwYAuL3Bv1FCPW+8Cvup32t52QCCFJYErq5y0oRh1ihkdc o4Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d82o4hPl2rrS2QtT2E3K50s/CbPBkgvsJM++mE8g3f0=; b=Gze/q4cTshQLrb1qIX/4j0hCDIbRAqgGpOphhcZ2vySO3zx7OOXTrjI9iywUd4SbMF 4JIpIhaDKC6FaHxeU8AEqvC5Zt/t4rEDBQO0QxZMcuOsYJeQcmy/fxCIvvKCGyreAkNI MUoq8pXItPE/7sCIKAlmcMTDPhxcfnpclTtsnkTrmbj5f2saQOISwmGdRcHVPujlw4rN ljJ0AA2W4e2hZKvgN7+zQ2/40ijihQQ1xwzzsPQIZL4S7NSb6humSE3Tl3AesIj29Bhl GpWJb4nGIaSvUyesYu5WJMRDSJ7EBGggbGn8ah3TTXYImMiP0L6vqkJsvfWiqbhIXg5T N7UA== X-Gm-Message-State: APjAAAXR6o53NOOED7JEPBzLBOQa10jghQAa+a3PsQlBN/pxWj9jF/IA lAhD/CeawZyYdmehhTyj5tTimhVAPtOHVDLU3hGUyA== X-Google-Smtp-Source: APXvYqxLBKrT0Gl6WsArDeH1i8G/E6vsHzHySFIPNs84BaSr+/4UxxowsT93FFacKFvO8dW7lUXTjImOt4++8OEwyk8= X-Received: by 2002:a05:620a:12d0:: with SMTP id e16mr19675318qkl.140.1554831444661; Tue, 09 Apr 2019 10:37:24 -0700 (PDT) MIME-Version: 1.0 References: <201904081825.x38IPEpV054311@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 9 Apr 2019 11:37:13 -0600 Message-ID: Subject: Re: svn commit: r346039 - head/sys/conf To: Rebecca Cran Cc: Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 5F5F56FBE4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.973,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 17:37:26 -0000 On Tue, Apr 9, 2019 at 11:19 AM Rebecca Cran wrote: > On 2019-04-08 12:25, Warner Losh wrote: > > Author: imp > > Date: Mon Apr 8 18:25:14 2019 > > New Revision: 346039 > > URL: https://svnweb.freebsd.org/changeset/base/346039 > > > > Log: > > Style only change: Prefer $() to `` > > > > $() is more modern and also nests. Convert the mix of styles to using > > only the former (although the latter was more common). It's the more > > dominant style in other shell scripts these days as well. > > > > Differential Revision: https://reviews.freebsd.org/D19840 > > > > Modified: > > head/sys/conf/newvers.sh > > > > Modified: head/sys/conf/newvers.sh > > > I thought I saw an email a few weeks ago that suggested that the list of > people who reviewed the patch should be copied into a "Reviewed by:" > line, to avoid only having that information in Phabricator. > > Am I remembering correctly, or is just mentioning the Phab review > considered sufficient? > You remember correctly. Sadly, there's no automation to make it happen, so it's easy to forget. I hate the notion that came out of the last discussion, but am trying to do it, but since there's no automation, I'll fail to do the right thing more often than not. Warner