From owner-freebsd-current@freebsd.org Fri Dec 30 21:00:21 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6B4FC98EC6 for ; Fri, 30 Dec 2016 21:00:21 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4189019D5; Fri, 30 Dec 2016 21:00:20 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from thor.walstatt.dynvpn.de ([92.224.249.53]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MOSNd-1cQfJT3P7N-005n3O; Fri, 30 Dec 2016 22:00:15 +0100 Date: Fri, 30 Dec 2016 22:00:07 +0100 From: "O. Hartmann" To: Toomas Soome Cc: Dimitry Andric , "O. Hartmann" , FreeBSD CURRENT , Toomas Soome Subject: Re: r 310850: buildworld failure due to: nandfs.c:1049:15: error: too many arguments to function call, Message-ID: <20161230220007.517c6586@thor.walstatt.dynvpn.de> In-Reply-To: References: <20161230202338.73e7d00b@thor.walstatt.dynvpn.de> <30C71053-94F3-44D1-9089-CE31E67912DF@FreeBSD.org> Organization: WALSTATT User-Agent: OutScare 3.1415926 X-Operating-System: ImNotAnOperatingSystem 3.141592527 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/eJ279oHP8hIxcOSXE4.DoHp"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:QmXahGl7lqCm2LWolU2DKX2lh9hA7Fp+p/mxVougtS48O3tpyf7 lSOEt+RefprNP+bnHIHRAesFLgX6H/D1s7ziE9tJLnCJ343nVu+OXYF6ToXyjEHqbOLEj2P sLCKw4uy6d7eXJ6aTvYz0JR495ZykaCIN3hjUFfaIS7XStTtM7G4GrQd23QZQdMLqcUXsHT i7R/jXrr8naHkZryZi9PA== X-UI-Out-Filterresults: notjunk:1;V01:K0:4cUe7RHKIVs=:nL/il28nykocSG0cJFhe6g d9ylRkhz+dSlYwgmROSBxSFgaIg47rzQxqPERYLU9sH3p7ufKVYtabyn8l0RD8aQrV0oeFLQm nHC+pIPxeT69bIW3uvea4vcjC06Sq3y0ZJ/bPXF5YrTkusK/lags4+9WQ09ZCBKraaS0JUj7e 2QJ+pbSN2EjmP4u5+6izKh0/XvcnCutPfx/E2kFGlEn+zz97tjeO9cdR0mla8yyJXwez+/FL9 9q7B+4Bb5Yc12mFu1Q/oeZLF/4kGd54AeonQqAHyp7kFDS+r/7SEaJ9wCk4pdCNo7IBvNLp7h mAHdXkRd/i+dKD3M6lj/jWNqjkhaoVACQ6S8N1EeYjAfhEVEe5r1Q9tSmMt/wTBYleDLDuym3 UHrsdO+VBgasgR9R0VP6s5syX47/4hMBoy1j+hubPDRg7Vp+8+xmnlikvtMDxmkmxM/n3COEy FsZ7AarqprvVXey8QJRBAuUYloxtsMzHqi+kFSVDgz+9dp4QHXVwJG387Bffd4Rx+2ZZFTfqN e8sspUYElDKSwzI6+adqn0CzlvH4ATbDuzAK/dwGXYqV26Brhjw50C1iH2Nl2PP4gPbqr9EKL NBvtmI9hW+S5MUI8R9JDU9RG9dSDMo9tyHLiamaEg3ALSFK649mHqeWqdAz3ERbkrOoGthnMI VE22dlNfeMDeb0Gug1hQNPR39XqeiFXXr5yR0j/dpAZ9qEytPoHFrQG3nl0syzA3fkhqqNQf5 /1//3Rzhei3rNSBHf8OPWCM/wHFIyfY3T/JEgSFsv+TZWy5gv2u5ePl62Ok= X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2016 21:00:21 -0000 --Sig_/eJ279oHP8hIxcOSXE4.DoHp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am Fri, 30 Dec 2016 21:40:27 +0200 Toomas Soome schrieb: > > On 30. dets 2016, at 21:35, Dimitry Andric wrote: > >=20 > > On 30 Dec 2016, at 20:23, O. Hartmann wrote: = =20 > >>=20 > >> Recent update of CURRENT to 2310850 fails with buildworld error: > >>=20 > >> [...] =20 > >> =3D=3D=3D> lib/atf/libatf-c++ (all) =20 > >> --- all_subdir_lib/libstand --- > >> --- nandfs.o --- > >> /usr/src/lib/libstand/nandfs.c:1049:15: error: too many arguments to f= unction call, > >> expected 6, have 7 buffer, NULL); > >> ^~~~ > >> /usr/obj/usr/src/tmp/usr/include/sys/_null.h:32:14: note: expanded fro= m macro 'NULL' > >> #define NULL ((void *)0) > >> ^~~~~~~~~~~ > >> 1 error generated. > >> *** [nandfs.o] Error code 1 =20 > >=20 > > This looks like the culprit to me: > >=20 > > On 30 Dec 2016, at 20:06, Toomas Soome wrote: =20 > >> Author: tsoome > >> Date: Fri Dec 30 19:06:29 2016 > >> New Revision: 310850 > >> URL: https://svnweb.freebsd.org/changeset/base/310850 > >>=20 > >> Log: > >> dosfs support in libstand is broken since r298230 > >>=20 > >> Apparently the libstand dosfs optimization is a bit too optimistic > >> and did introduce possible memory corruption. > >>=20 > >> This patch is backing out the bad part and since this results in > >> dosfs reading full blocks now, we can also remove extra offset argument > >> from dv_strategy callback. > >>=20 > >> The analysis of the issue and the backout patch is provided by Mikhail= Kupchik. > >>=20 > >> PR: 214423 > >> Submitted by: Mikhail Kupchik > >> Reported by: Mikhail Kupchik > >> Reviewed by: bapt, allanjude > >> Approved by: allanjude (mentor) > >> MFC after: 1 month > >> Differential Revision: https://reviews.freebsd.org/D864 =20 > >=20 > > For some reason, your build seems to pick up an older stand.h header? > >=20 > > -Dimitry > > =20 >=20 >=20 > oh, apparently I *still* did miss one strategy call in nandfs.. Sorry, I= =E2=80=99ll try to fix > it asap. >=20 > rgds, > toomas That has been fixed, thanks. But another bug in CARP makes buildkernel failing ... --=20 O. Hartmann Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Abs.= 4 BDSG). --Sig_/eJ279oHP8hIxcOSXE4.DoHp Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iLUEARMKAB0WIQQZVZMzAtwC2T/86TrS528fyFhYlAUCWGbK2AAKCRDS528fyFhY lC6zAgCemxE4iN3NOBtxj80aJ1QqKJYKWgHbCcHYyqgF9qryW1CA1ecwli+INTTi uTMw2Yw8bFRVMEh5YoOPf9y/TACTAgCmVY6+v8QabJ6JSaf/6O4DPtURDiK/JZ2p 6aoSW8+NiijmuBd5zxCWDhZ/b1twnasM7vH8WSIasgYa77niy43g =MsLd -----END PGP SIGNATURE----- --Sig_/eJ279oHP8hIxcOSXE4.DoHp--