From owner-freebsd-usb@FreeBSD.ORG  Sat Nov 12 08:43:03 2011
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 71450106564A
	for <freebsd-usb@freebsd.org>; Sat, 12 Nov 2011 08:43:03 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe08.c2i.net [212.247.154.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 07E1C8FC12
	for <freebsd-usb@freebsd.org>; Sat, 12 Nov 2011 08:43:02 +0000 (UTC)
X-T2-Spam-Status: No, hits=1.0 required=5.0 tests=ALL_TRUSTED,
	BAYES_80
Received: from [188.126.198.129] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 203480284; Sat, 12 Nov 2011 09:43:00 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Date: Sat, 12 Nov 2011 09:40:10 +0100
User-Agent: KMail/1.13.5 (FreeBSD/8.2-STABLE; KDE/4.4.5; amd64; ; )
References: <CAB-7mS6-kZk_Vxyd+Q-cGBEdAzqw=-QAh4GnH2OPVYC1fE5hqA@mail.gmail.com>
In-Reply-To: <CAB-7mS6-kZk_Vxyd+Q-cGBEdAzqw=-QAh4GnH2OPVYC1fE5hqA@mail.gmail.com>
X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5
	%V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC(
	:AuzV9:.hESm-x4h240C`9=w
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201111120940.10981.hselasky@c2i.net>
Cc: 
Subject: Re: [uslcom][patch] Add GPIO support
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Nov 2011 08:43:03 -0000

On Friday 11 November 2011 22:06:19 JD Louw wrote:
> JD Louw <jdl.ntq@gmail.com>

Hi,

In IOCTL's you shouldn't cast *(uint8_t *)ptr to *(int *)ptr and forth and 
back, because this only works on little endian machines.

Else your patch looks very good. I'm impressed.

Please download the latest version of the uslcom driver and test that nothing 
is broken.

Thanks for your patch submission!

http://svn.freebsd.org/changeset/base/227463

--HPS