From owner-cvs-all  Thu Oct  8 21:23:04 1998
Return-Path: <owner-cvs-all>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id VAA15153
          for cvs-all-outgoing; Thu, 8 Oct 1998 21:23:04 -0700 (PDT)
          (envelope-from owner-cvs-all)
Received: from time.cdrom.com (time.cdrom.com [204.216.27.226])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA15117
          for <committers@FreeBSD.ORG>; Thu, 8 Oct 1998 21:22:47 -0700 (PDT)
          (envelope-from jkh@time.cdrom.com)
Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1])
	by time.cdrom.com (8.8.8/8.8.8) with ESMTP id VAA04400;
	Thu, 8 Oct 1998 21:22:30 -0700 (PDT)
	(envelope-from jkh@time.cdrom.com)
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
cc: committers@FreeBSD.ORG
Subject: Re: cvs commit: src/libexec/getty main.c 
In-reply-to: Your message of "Thu, 08 Oct 1998 22:08:33 EDT."
             <199810090208.WAA21237@khavrinen.lcs.mit.edu> 
Date: Thu, 08 Oct 1998 21:22:29 -0700
Message-ID: <4396.907906949@time.cdrom.com>
From: "Jordan K. Hubbard" <jkh@time.cdrom.com>
Sender: owner-cvs-all@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> <<On Thu, 08 Oct 1998 18:16:56 -0700, "Jordan K. Hubbard" <jkh@time.cdrom.com
> said:
> 
> > See the change in question. :)
> 
> <bde>
> All sorts of things wrong here.  Looking at the header file which
> started all this:

This is an amazingly accurate imitation - you can almost hear the
australian accent! :-)

> System headers go first.  Header files should never include other
> header files, except for certain system headers and as necessary to
> meet formal Standards.

Hmmm.  formal Standards.  When you figure out what those are,
including the ones in the wake of our "cleanup" which have caused
certain interfaces to no longer behave as described in their own man
pages (in terms of what must be included as a prerequisite), kindly
let me know. :-)

> This violates just about every rule in style(9) pertaining to
> structure declarations.

Not bad for 6 lines, eh? :)  I'll check it against style(9),
but don't expire from held-breath or anything in the meantime.

> 	/* for auth.c */
> 	#define _PATH_AUTHCONF	"/etc/auth.conf"
> 
> System paths go in <paths.h>.

Will move it.  I didn't like it there either, it was just a place-holder
so Mark could get on with his work.

> declaration of functions in heaer files.  This whole debacle
> illustrates properties_read(), and non-Standard library functions
> generally, should not take `FILE *' arguments.  It should be an fd, or

A nice goal, but much less easy in practice.

- Jordan