From owner-cvs-all@FreeBSD.ORG  Fri Mar 30 17:16:42 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0BAA6106566B;
	Fri, 30 Mar 2012 17:16:42 +0000 (UTC)
	(envelope-from kozlov@ravenloft.kiev.ua)
Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [94.244.131.95])
	by mx1.freebsd.org (Postfix) with ESMTP id BA2778FC1C;
	Fri, 30 Mar 2012 17:16:41 +0000 (UTC)
Date: Fri, 30 Mar 2012 20:16:40 +0300
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Max Brazhnikov <makc@freebsd.org>, ports-committers@freebsd.org,
	cvs-ports@freebsd.org, cvs-all@freebsd.org
Message-ID: <20120330171640.GA42284@ravenloft.kiev.ua>
References: <201203301436.q2UEaXor009896@repoman.freebsd.org>
	<201203301540.40388.makc@freebsd.org>
	<20120330155456.GA34807@ravenloft.kiev.ua>
	<201203301711.10202.makc@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201203301711.10202.makc@freebsd.org>
Cc: 
Subject: Re: cvs commit: ports/games Makefile ports/games/drcreep Makefile
 distinfo pkg-descr pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Mar 2012 17:16:42 -0000

On Fri, Mar 30, 2012 at 05:11:09PM +0000, Max Brazhnikov wrote:
> On Fri, 30 Mar 2012 18:54:56 +0300, Alex Kozlov wrote:
> > On Fri, Mar 30, 2012 at 03:40:39PM +0000, Max Brazhnikov wrote:
> > > And by the way ${ECHO_CMD} should be used, if you really need echo.
> > Do You mean ECHO_MSG?
> It depends. The bsd.command.mk says:
> 
> # ECHO is defined in /usr/share/mk/sys.mk, which can either be "echo",
> # or "true" if the make flag -s is given.  Use ECHO_CMD where you mean
> # the echo command.
> ECHO_CMD?=	echo				# Shell builtin
> 
> # Used to print all the '===>' style prompts - override this to turn them off.
> ECHO_MSG?=	${ECHO_CMD}
But the Porters handbook says:

Likewise, the distinction between ECHO_MSG and ECHO_CMD should be kept in mind.
The former is for printing informational text to the screen, while the latter
is for command pipelining.

A good example for both can be found in shells/bash2/Makefile:
update-etc-shells:
	@${ECHO_MSG} "updating /etc/shells"
	@${CP} /etc/shells /etc/shells.bak
	@( ${GREP} -v ${PREFIX}/bin/bash /etc/shells.bak; \
		${ECHO_CMD} ${PREFIX}/bin/bash) >/etc/shells
	@${RM} /etc/shells.bak


--
Adios