stfix) with ESMTP id A08D7C6672; Mon, 27 Apr 2026 16:44:36 -0700 (PDT) To: "Enji Cooper (yaneurabeya)" CC: =?us-ascii?Q?=3D=3Fus-ascii=3FB=3FPT91dGYtOD9RP0RhZy1FcmxpbmdfU209QzM9?= =?us-ascii?Q?QjhyZ3Jhdj89=3F=3D?= , , , , Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently In-Reply-To: References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net> Comments: In-reply-to: "Enji Cooper (yaneurabeya)" message dated "Mon, 27 Apr 2026 16:20:12 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.8; Emacs 30.2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Apr 2026 16:44:31 -0700 Message-ID: <6875.1777333471@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6730:EE_|SA3PR05MB11076:EE_ X-MS-Office365-Filtering-Correlation-Id: 34d4030b-d7d7-422e-2b5a-08dea4b6f145 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: VL4kUIcxVcWx6Bl2wxRUQx6DjY73iJnw5N4FrDmYykrsKtDgqLGpI7Feji/KVjst1tky0N3y450nrsT5y6tHA25t41hEaYKERp8qb1olTB83jTKJOv9xWlyvyY5jVu01o1+vjVh1vjLtxOQxkklESqFq+LjCjDASqqZ+PFafMmmAk5IlhAeW8hTYSQAyZTk1nAAMdpF0a3O0qNPEQWvrem0leQ89MlAMmmYLGkKeKEzRazguMomaObT0PESvsAZjogQ2sECxZQjfz6lxROfqw47HlcrV+tE53paNAGwGkE8FRkQ03/vEa3i5pWM7+K/ymItm2jyeSIIl5aRe9shh7hmr+eJLeMWlDkE77xK0IH6yLl1rE1bosaIr+VvZmx4Y7ObjJQYbfRlYiFIGEhVX9qPunJW++Bb4ck/BzObpaLU6FjS9bzJ2NZIaneYq08OE4R1FerFhRW7jKWOEYoetKIRoLPh3J+VQhnoFRXVC23M5+kdXWyXp2+CmIpSH59NCn6mCHqY1EVpaiScVmsPke90vSMpwjMbQgf1lnomsbf2NK/LLMAvnpVp+G13M2gCIbxVBylQ0VJosmHSQ5BL4a+KT6XJ1leyGOho4BAHjekag2qZqQQ56YkDmldAyTZxtIzZP6j1BBVG7fs8DWYgyCePZjShd/PVJFzvLRc29I3mFBqcZu7JN+95RNCPRHcYSbqGBQk93JvgMxAzczJFsRWVppEX5jk1t0KY0H39tfZHutUGleadZJxfWSC8/STz/Qo5fZfDsthvKSMtIEQbUNA== X-Forefront-Antispam-Report: CIP:66.129.239.14;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:juniper.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: m/DOYp2+Ym+LfUIgJB7YzrCDeTEKnNrFFQey7O9XSvy+pXmJQh0xCn09OUq0YlZJ/YfTJ+da6rtpp4Rlw6sdELtPJVfUQxNB9yv1j6ZMPbksRG1wJqWRWG67sUk2bp/QesCt/RoIfGR+EMlG4p9hPNkdndgRDP1WCwjYbaekFKU9nu55iHt6Rm3hrTDF2igJcKn0on6lpOKxa6LDTvgea1GI0VkC8OtUSLyOSMTUH7hejZxWO6gzfW5lk1NCIh8IqWcWwKSS+FuqQ0L0BGq2ILJ4pzSQGNPNNBO7yqQVyGpj/fVBej46TJY9q/0GjOtWQuW9PhMCtX3zDkMSgh4jG8kLi8QLioyAPlt15w/K/rq/vnOEN+CX2p+JtMwZEa2+NRxwZPKvWK8ux29pgcN1H9UeehldU4JtnmunMdky5UKAdHuylktKQp+Ldvjdz7if X-Exchange-RoutingPolicyChecked: FoRhz1xMLAxVIRAFwaPoa2KGAvx/aI3MoG0yKrM7NR5tRCPrJptOJQCWv+pl76yKgYt2yyEAW4aISQVo6KMk9IY5N+MLjjlJxIuTAiEhgg94y8UGDt+7oRJfcamw6VAYlATvGZljRGMXmCvHmMzL5ghn5I5EsALRoXgD50i3eSscKEh9vkhlJVAvPtgnQwSkCncBZdHANHp69bqOxt5luQ5PAs37D5It9Hn+n3Azv8h2ZdG6D9e1VDMf5YMQ0jbLOKQpAGF6xann5YwEglNxE+LZDEi01lF892vD7tcoaVnetTA7eqySBt0HZSOz1K7tFzNjc4ZRZRNsPjHAP61xuA== X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 23:44:37.1452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34d4030b-d7d7-422e-2b5a-08dea4b6f145 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.14];Helo=[juniper.net] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6730.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR05MB11076 X-Proofpoint-ORIG-GUID: TzeZq_sKqGCQmaWsrhWUDouW_rNHVWss X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDI1MCBTYWx0ZWRfX1iIGIi/ifyBQ ILo/34HMSyJ3pVBruPqXVulkKzbrz0MRpHKaVNGpufiW6sxvUdeRrwIfWmeq6qmDcBYdW6sJWUq 0wXJeiMi0BH643CNH008kbuJaTnWKX0+fodf63jIc7OBn7usdzXyYRB+TG/oP+rXp7GD1eXs0sH li8VvwFRaNqhvyFC3CrBUm4Pm3fhhZMhC1ivABdlcKJYNH0mls/+luYTbsfIfdM7C9u7kni3Twu 0ez6EOYQxH72plijfCjzU+c5AUDSVoTfNvN3b4TWsuvMvOa7Q0zmrkw4W0L4mHfmaMH9CejKQos AdhD24HcjENlfPMW2oe9I44F9Wos83hDem2Z0doCRwTDy67FtXUPJnNz7x0k+jzmjrvF1vLj2mk fo2CRYRP0UmlaZolDrPuY2SaAuilTTBUkSYerqXqiEbQe2bQvH0o2dpYNcG+dlJ3+PHNLCku1UQ gypfrt9L2hJiJWXoWTw== X-Authority-Analysis: v=2.4 cv=cOXQdFeN c=1 sm=1 tr=0 ts=69eff4e9 cx=c_pps a=aOchWjQmdX1ADhYh+yUFEQ==:117 a=f/rncuQqEjTEF/G1odkJ9w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s63m1ICgrNkA:10 a=rhJc5-LppCAA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7vL3O5uBSuztJ3xaqtyr:22 a=3yS7yMrOVflTMqpn9XM3:22 a=pGLkceISAAAA:8 a=bXROpxAjXP2mNnUUKgYA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: TzeZq_sKqGCQmaWsrhWUDouW_rNHVWss X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 clxscore=1011 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270250 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US] X-Rspamd-Queue-Id: 4g4Kt24Jbpz3w1l X-Spamd-Bar: ---- Enji Cooper (yaneurabeya) wrote: >=20 > Using `:` as a comment marker seems a bit esoteric (at best) =E2= =80=94 Using : in the manner I described is extremely useful for being able to debug complex systems written in sh. There is no useful alternative. The change is harmless, and allows safe_set to be re-used in other contexts. I see zero benefit to reverting it.