From owner-freebsd-current@FreeBSD.ORG Sun Nov 18 06:06:45 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34FF616A421 for ; Sun, 18 Nov 2007 06:06:45 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.182]) by mx1.freebsd.org (Postfix) with ESMTP id E45B213C45B for ; Sun, 18 Nov 2007 06:06:44 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so1642751waf for ; Sat, 17 Nov 2007 22:06:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=Q9ew+Eooi0Wsy7mUi1km2DeF5ZguL9qkOfl8zOpWyA0=; b=FA/cRif7hbvQZ9MjSgsCr1HTBbQJt/d24Y6L9+xpXGAoek82e80383dX06WJSQX6Vy/U79G7dftlEPc9LfRlPSJ5Key024J31C69L0AUW1OYwXkqvIw6lP89jHzdtx200imUnuEe13AArmpmXUD3JVXGzBl0cNEolrCwTuOEcBY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=trLJvyoQVrDfkcOI09559FIfZg0HXrM2H3BK/Mmtl63vXQa36E6a6TjPpL0+rJJ1qx6DPBGwEbggJ67D3DUDCHdvEpXLjWe4HJABQXp+LBmhxmboleSRl976TYFE85lkqSEGbxmpZ2OXLP2ykJKMTRJTfq4S7ekLIRp+J2hRvCA= Received: by 10.115.59.4 with SMTP id m4mr73854wak.1195365994261; Sat, 17 Nov 2007 22:06:34 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id v37sm5068148wah.2007.11.17.22.06.28 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 17 Nov 2007 22:06:32 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id lAI64dMG001709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 18 Nov 2007 15:04:39 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id lAI64cZs001708; Sun, 18 Nov 2007 15:04:38 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Sun, 18 Nov 2007 15:04:38 +0900 From: Pyun YongHyeon To: Jack Vogel Message-ID: <20071118060438.GB1044@cdnetworks.co.kr> References: <20071117170537.F59492@mindcrime.int.bit0.com> <20071117182232.T59492@mindcrime.int.bit0.com> <473F9552.50402@bit0.com> <473FBD1A.8010207@bit0.com> <20071118054409.GA1044@cdnetworks.co.kr> <2a41acea0711172200n160ff8f2rb2d0b81dfab236ea@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a41acea0711172200n160ff8f2rb2d0b81dfab236ea@mail.gmail.com> User-Agent: Mutt/1.4.2.1i Cc: Mike Silbersack , Andre Oppermann , Kip Macy , Denis Shaposhnikov , freebsd-current@freebsd.org, Mike Andrews Subject: Re: bizarre em + TSO + MSS issue in RELENG_7 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2007 06:06:45 -0000 On Sat, Nov 17, 2007 at 10:00:16PM -0800, Jack Vogel wrote: [...] > > > > It seems that em_tso_setup() doesn't clear txd_upper/txd_lower in > > failure path so that unintialized value could be used in subsequent > > Tx descriptor setup. > > How about clearing those variable?(Patch attached) > > > > It seems that em(4) uses EM_TSO_SIZE(64K) to create DMA tag. A packet > > can have 64K payload under TSO so its the mximum size of the mbuf > > chain would be 64K + sizeof(link layer). So I guess the EM_TSO_SIZE > > should be increased to hold sizeof(link layer). > > It had been a long time since I looked into em(4) so I'm not sure. > > Huh? They are set to 0 on entry, and not touched again before you go > into the setup routine, your change has no effect. > Sorry for the noise. -- Regards, Pyun YongHyeon