From nobody Sat May 16 21:25:48 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gHxv060mBz6d5vM for ; Sat, 16 May 2026 21:25:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gHxv05HKgz3nY9 for ; Sat, 16 May 2026 21:25:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778966748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MupTa/AJc1W3SYIvCcBMLRKYIu7QXb3LRyrPWSWQn9Y=; b=jiRMntIVLWBAs3H8P8P96RBCvrnpwRKLKwLeioNsws3mMAxcFh/+v2IOl+I5UTEEFsqdsY ikCzVdirgx+ajqpmw40WJrB5lY/j/HtDx6SkDJZg0viFSTfZef5y4u6d/t9SBHnNObP2xJ 6zDCkoWs3WCm1YDxj4flpb/eT0f5IqHuBuC99F5BgikSoEyf2VLMCm+lXeht2GRjPvfjDx RaEzBoO5tlQdPy3TBhyoD7q6Mx4Sq+rwFO89yrmfOe7MWkK88RRlf6gUaTuYuyMwXqIhkZ OeodL1N2j8rRSQJyIjCO9xxrwHMVI+BI13xHMDI/mD/OAEJV1VADN+M2Mf4MJA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778966748; a=rsa-sha256; cv=none; b=ffxC7GCTkPF3jNZqoIbWE2PgApg7HPhDxKBaXdYyRKB4qFNkccw5A/llEeuXlE/D2XKRqQ kdzjg93JHnB7r/+t/guFGBugIIRyG4WS4MOp9if1Yv2jXXocfcQE1IdzJguvsZafnGU6qA Dqx7pihgbi14vWERktOelI9NSY2UstXK5RPzUDon4C8YrBXQof6zRyg6Kv7kvm9ORKrIQd GqHYysUYyTYc6q7LcqSENKVBeWl2COG+9xIMBGaLuqlWg7PDX7M8APNZNkMjy1+uPMQdUZ lkQq4Cc6xJUzYPwg72u3giAcV3ct6d0io1jm0g0h/7WzkEaWYfbTbpMVJ3bJRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778966748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MupTa/AJc1W3SYIvCcBMLRKYIu7QXb3LRyrPWSWQn9Y=; b=qtw1rghYSrc0QSOAJwlrl4lzqYzbBdjqo56enUBHDT4jpHl7Ugz9mmuFON8r3lyLnOdBWT J9+DxWALg11SQvgymSo4JiXxD4gsh2/tMrrYhhmTfF6dpGSmkGqy/HrFv520lyhQZzxxJD UlzF3QNlbOJ3xUzUzXQmPQvf4EglDRW1F9eqpqSBhQkTzt8U9mkXqYgVsmijt8+IvvR/4G JWDohint4/VVVvLMvK/EDuCq5heARAiiVAgA5+yJ04cRfpjL1RBsf/PjrVp2LTWyqQTEiH UJ36OnWYY6V95T2J/tV0fgUNLhgxCqKfDLfJ9ls619olN9S7d4bnFvc2aNqxKw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gHxv04qqnz1B42 for ; Sat, 16 May 2026 21:25:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f89d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 16 May 2026 21:25:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 3e2308d57080 - stable/15 - rtnetlink: Check for allocation failure in nlattr_get_multipath() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3e2308d57080a2345e3db1139683368b504ee0bd Auto-Submitted: auto-generated Date: Sat, 16 May 2026 21:25:48 +0000 Message-Id: <6a08e0dc.3f89d.3a118d23@gitrepo.freebsd.org> The branch stable/15 has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=3e2308d57080a2345e3db1139683368b504ee0bd commit 3e2308d57080a2345e3db1139683368b504ee0bd Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-05-11 19:53:21 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-05-16 21:24:19 +0000 rtnetlink: Check for allocation failure in nlattr_get_multipath() Check for alloction failure on `npt_alloc()` for RTA_MULTIPATH attributes in `nlattr_get_multipath()`. Reported by: Joshua Rogers of AISLE Research Team Reviewed by: markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D56954 (cherry picked from commit 188631e43a1a5d2985156141c2e244a925670683) --- sys/netlink/route/rt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/netlink/route/rt.c b/sys/netlink/route/rt.c index 7641417a8e77..a76e00d34502 100644 --- a/sys/netlink/route/rt.c +++ b/sys/netlink/route/rt.c @@ -447,6 +447,10 @@ nlattr_get_multipath(struct nlattr *nla, struct nl_pstate *npt, max_nhops = data_len / sizeof(struct rtnexthop); mp = npt_alloc(npt, (max_nhops + 2) * sizeof(struct rta_mpath_nh)); + if (mp == NULL) { + NLMSG_REPORT_ERR_MSG(npt, "%s: too many RTA_MULTIPATH", __func__); + return (ENOMEM); + } mp->num_nhops = 0; for (rtnh = (struct rtnexthop *)(nla + 1); data_len > 0; ) {