From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6AA48DCBA0; Tue, 3 Sep 2019 14:06:34 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zZ18Xhz4PhT; Tue, 3 Sep 2019 14:06:34 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 0F6281A87C; Tue, 3 Sep 2019 14:06:12 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id B9F8D3669; Tue, 9 Apr 2019 20:40:30 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2E20480D7D; Tue, 9 Apr 2019 20:40:30 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 10C753651; Tue, 9 Apr 2019 20:40:30 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 67F653649; Tue, 9 Apr 2019 20:40:27 +0000 (UTC) (envelope-from chris@rees.space) Received: from mail70c50.megamailservers.eu (mail169c50.megamailservers.eu [91.136.10.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3779C80D75; Tue, 9 Apr 2019 20:40:25 +0000 (UTC) (envelope-from chris@rees.space) X-Authenticated-User: bayofrum@uwclub.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1554840594; bh=AgIPL71YtdLawN/iK/yjVVStgTCf+k1m4Dtp8wyS6o0=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=KZIqa/tf4E0BS87bGY9ab6Hzmfyz2kg3tJvq0rmvfj+Vj4Dz4+ZEl10bh3Jmqx3TW etT2bdsQTLBZMT0s8AO+5pT486xWSk0ozFnxDDKlqvo2ZJ4eTp4zU6iLUWCYwv8LzU 7KEKzGdKeJ+CzD8Un8qbzYOtxNpRA7t9COCAeObk= Feedback-ID: chris@rees.spac Received: from pegasus.bayofrum.net (81-178-238-70.dsl.pipex.com [81.178.238.70]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x39K9qHP005953; Tue, 9 Apr 2019 20:09:54 +0000 Received: from [192.168.1.121] (POSEIDON.bayofrum.net [192.168.1.121]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 155651B7A; Tue, 9 Apr 2019 21:09:48 +0100 (BST) Subject: Re: svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5 To: Chris Rees , rgrimes@freebsd.org, "Rodney W. Grimes" , Andriy Gapon CC: "O. Hartmann" , Chris Rees , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201904091955.x39Jt7PU061907@gndrsh.dnsmgr.net> From: Chris Rees Message-ID: <56770290-a7f2-07dc-3f5a-f9d5721db724@rees.space> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 155651B7A.A4F62 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: chris@rees.space X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B020E.5CACFC12.005F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ILcs9DnG c=1 sm=1 tr=0 a=i0HMBnJGy7D3/NFKO8d8XA==:117 a=i0HMBnJGy7D3/NFKO8d8XA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=oexKYjalfGEA:10 a=Y8a21bOVD5kA:10 a=ZZnuYtJkoWoA:10 a=iKhvJSA4AAAA:8 a=GN3eLU9uyxQDXXIByxQA:9 a=QEXdDO2ut3YA:10 a=odh9cflL3HIXMm4fY7Wr:22 Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 2E20480D7D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.96)[-0.965,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:14 -0000 X-Original-Date: Tue, 9 Apr 2019 21:08:53 +0100 X-List-Received-Date: Tue, 03 Sep 2019 14:07:14 -0000 On 09/04/2019 20:59, Chris Rees wrote: > On 9 April 2019 20:55:07 BST, "Rodney W. Grimes" wrote: >>> On 09/04/2019 21:33, Rodney W. Grimes wrote: >>>> I think the trigger issue is: >>>> grep zfs /etc/rc.d/zvol >>>> rcvar="zfs_enable" >>>> required_modules="zfs" >>>> >>>> that module requires may be going south with the >>>> new code when the module is built into the kernel. >>> Maybe it's because the module's name is zfsctrl (for whatever reason) >> while the >>> module file is named zfs.ko. >> I suspect that could also lead to issues with the new code. >> It seems to be failing to detect that zfs is infact functional in the >> kernel, >> and blindly, or not so blindly, trying to load zfs,ko, which when you >> build >> it into the kernel you usually do so without any modules built, so >> there is >> no /boot/kernel/zfs.ko, and even if you did build it any attempt to >> load >> it would return an error. > Loading with it built in isn't a problem, as I showed earlier. > > Loading when it doesn't exist *is*. > > I'm torn. Either we could revert this, or add a check to the required_modules function instead, which I think is the better solution. Hang on, [crees@pegasus]~% sudo kldload -n zfsctrl && echo yes yes [crees@pegasus]~% find /boot -name zfsctrl\* [crees@pegasus]~% I think that, rather than speculating, we should wait for Oliver to confirm that this is actually the problem, because I still don't think it is. Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.