From owner-svn-src-all@FreeBSD.ORG Mon Jan 11 12:19:45 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA95F1065672; Mon, 11 Jan 2010 12:19:45 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id E6D5B8FC17; Mon, 11 Jan 2010 12:19:44 +0000 (UTC) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.3/8.14.3) with ESMTP id o0BCJfCQ057583; Mon, 11 Jan 2010 15:19:41 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1263212382; bh=ZlQLnLzJDeDKYx+eEuk2LIuA0SMakdBizeDeiir2S9Y=; l=1013; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=NCt6BIr/aJiYw+ytKji4U/sOBD6aFZVUsyfwR0fWjEDiiXMNERXVp6RDfouylAnUq NdMx9/WrbuWipU71KfjcGQtNXdbh9lYXwBcqmXVKrl7CTFEJLDxFT0T5vMVDfRH5pe ONhS+LTKEH5C57ck5E6+gEQPfNbyh4NLnbOmyZp0= Received: (from ache@localhost) by nagual.pp.ru (8.14.3/8.14.3/Submit) id o0BCJenO057582; Mon, 11 Jan 2010 15:19:40 +0300 (MSK) (envelope-from ache) Date: Mon, 11 Jan 2010 15:19:39 +0300 From: Andrey Chernov To: Bruce Evans Message-ID: <20100111121938.GA57442@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Bruce Evans , Colin Percival , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201001101430.o0AEUURS051917@svn.freebsd.org> <20100110212548.GA47331@nagual.pp.ru> <4B4A5252.9070205@freebsd.org> <20100111134429.F1302@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100111134429.F1302@besplex.bde.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Colin Percival Subject: Re: svn commit: r201999 - head/lib/libc/stdio X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2010 12:19:46 -0000 On Mon, Jan 11, 2010 at 02:29:03PM +1100, Bruce Evans wrote: > >> 3) errno should be EOVERFLOW, see other owerflow checks in the stdio. > > There are none. I (we?) intentionally didn't set errno when the correct F.e. see fseek()/fseeko() stdio checks, as POSIX says: [EOVERFLOW] For fseek(), the resulting file offset would be a value which cannot be represented correctly in an object of type long. [EOVERFLOW] For fseeko(), the resulting file offset would be a value which cannot be represented correctly in an object of type off_t. Moreover, POSIX tends to introduce EOVERFLOW now in many places like old system calls too, see read()/pread(): [EOVERFLOW] The file is a regular file, nbyte is greater than 0, the starting position is before the end-of-file, and the starting position is greater than or equal to the offset maximum established in the open file description associated with fildes. (IEEE P1003.1 Draft 5.1 Issue 7 quoted in both cases) -- http://ache.pp.ru/