From nobody Mon Feb 14 12:08:23 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7312C19BBE94; Mon, 14 Feb 2022 12:08:36 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jy30M09hNz4rRp; Mon, 14 Feb 2022 12:08:34 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 4FA50126225; Mon, 14 Feb 2022 13:08:25 +0100 (CET) Date: Mon, 14 Feb 2022 13:08:23 +0100 From: Piotr Kubaj To: Jan Beich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 98b88b839df1 - main - x11/cde: actually fix build on powerpc64le Message-ID: References: <202202141141.21EBfLVh090770@gitrepo.freebsd.org> <4k51-slp1-wny@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yotjpMnqJyoIoG2Y" Content-Disposition: inline In-Reply-To: <4k51-slp1-wny@FreeBSD.org> X-Rspamd-Queue-Id: 4Jy30M09hNz4rRp X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=reject) header.from=anongoth.pl; spf=pass (mx1.freebsd.org: domain of pkubaj@anongoth.pl designates 46.248.190.61 as permitted sender) smtp.mailfrom=pkubaj@anongoth.pl X-Spamd-Result: default: False [-5.39 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[pkubaj]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.993]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --yotjpMnqJyoIoG2Y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 22-02-14 12:59:38, Jan Beich wrote: > Piotr Kubaj writes: >=20 > > The branch main has been updated by pkubaj: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D98b88b839df1a88f538b8b= fdc74e9734b0df7ea3 > > > > commit 98b88b839df1a88f538b8bfdc74e9734b0df7ea3 > > Author: Piotr Kubaj > > AuthorDate: 2022-02-14 11:38:50 +0000 > > Commit: Piotr Kubaj > > CommitDate: 2022-02-14 11:38:50 +0000 > > > > x11/cde: actually fix build on powerpc64le > > =20 > > This port doesn't respect setting FLAGS via Makefile, so -DPOWERPC6= 4LE goes unnoticed. > > =20 > > Switch to ifdef __powerpc64__. > [...] > > -.if ${ARCH} =3D=3D powerpc64le > > -CPPFLAGS+=3D -DPOWERPC64LE > > -.endif > [...] > > -+#ifdef POWERPC64LE > > ++#ifdef __powerpc64__ > > + tmpval =3D va_listval(va_arg(ap, va_listarg)); > > + va_copy(ap, tmpval); > > +#else > > + va_copy(ap, va_listval(va_arg(ap, va_listarg))); > > +#endif >=20 > Do you intentionally ignore endianess here? __powerpc64__ is defined on > both big (aka ARCH=3Dpowerpc64) and little (aka ARCH=3Dpowerpc64le). Yes, powerpc64 has actually the same issue, but fixing it here causes segfa= ults (probably endianness-related) later on during build. --yotjpMnqJyoIoG2Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmIKRjcACgkQelmbhSCD nJ0PPBAAxJaT9KFkFUgk9OCiV5oiJ5SE5+qK+eTdjS6Xc/F53u+T0CkcJ/88DMeS 1crWRW+bhW+QHXfyYwK9JW8j86LTkUuiP996y4QTrBwpsB34qQIclD4lvVk0G3W/ kOBiBqZhfcRUgyagh9ZJu5uMjORFOfeOzZ/SjSzWOiitc7OPqZ4VVT4js/4pjCgz wrNnCLKk9YfnCK20VuPYpbAqV9RijSm/hHmXrXarQelXNtYNsUuBOrUOQgHanOSb 1Pr4ITa9xYhlHaiHgWOfV+5FoH8N05m9cmhfXo+LAPhQuluCgFhPIT1MRQB8MCWG ZOYMpKrkFdMTTPgJAzqioS62HtTBh6n5qNANrrm1hzXiEOXdS+/iQtXZ+VHMEBXp M/gV3elctwfj5k1u/kk3ZZ04wh9svJPu6iXGLzUudt+cf5Zi99K282o9YmZETBFh VVoI0YZwupASu2DRWqdPgGQrKiXYOgKwNz22xbnvVETiEJV1wFjR3U+B739UnWiP ujINS1I1ZH0enfTChgiuPR1ZnnRJMUEE6gSxpVZxN2PMwiLRV+n5u4gCvO9/LNnB yA8vlw3YVW0GkDvVFoppFs1qcAEDZ6byuQcA9/ooJ3+j8n2SFrkU2w3L4+oud9VH L+QYHwG0rHD1RUmZNRBZczkWFl5t3Gu4YyJPouJCs6knJ16+g8Y= =AhHf -----END PGP SIGNATURE----- --yotjpMnqJyoIoG2Y--