From nobody Tue Nov 23 19:34:18 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 37A66189FFEB; Tue, 23 Nov 2021 19:34:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HzDpy6dNDz3nWZ; Tue, 23 Nov 2021 19:34:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C420F1C716; Tue, 23 Nov 2021 19:34:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1ANJYIjY042852; Tue, 23 Nov 2021 19:34:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1ANJYImR042851; Tue, 23 Nov 2021 19:34:18 GMT (envelope-from git) Date: Tue, 23 Nov 2021 19:34:18 GMT Message-Id: <202111231934.1ANJYImR042851@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org From: Rainer Hurling Subject: git: 75007752abec - 2021Q4 - graphics/qgis: Fix on CURRENT after llvm13 intro List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rhurlin X-Git-Repository: ports X-Git-Refname: refs/heads/2021Q4 X-Git-Reftype: branch X-Git-Commit: 75007752abec044026edbb53aa0742cc47b49a89 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637696058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NUO9uxeMLsy2qFjiy9S3fiQ7PckP+A7wpCqYtsp4OjE=; b=lpdB70dM0mir2DuL7f9784jpuJqCVrRipGrZx1NppBrvL3AeGBdvPLU8BlBBRq30h98psh ddXYFOSjuwqYk8PAGXPyWvwMAnYC+uME6q98OZrqSILHeI38qGKeOTKs3P/k6u2WqroiAs 7sVved/lY2E+JyimoZg+uj+3+Pl3++zn/020aYMQB9a3EsgEG4m48sRm48aHAC8Q5tgpze g+qCpJQk468Vd0WeDm+679Eqbo/e9+LEhL5r2htGknyihnACUy9BkmecUT6Pl49b9AgZ8E jirD3VQfIGop2Q1sBQ2kQ6BHHiTqGypGuy/JnaJtYfQPWASIN5Tdnazj8nIG5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637696058; a=rsa-sha256; cv=none; b=txR7fAIWmbMiWd1/hSuR9WgUWH05oaImBJVCHPgQiq3bXTkXLCwCmcl6I/rnH+uWakhzil cig6orgpKUURiOrs46yuEaFKPT0aw6AQce8b4g2cdHm3R3KZ+fb+7tGsqktXbU4XXLtIWo sCR6KuKJlArSHuWwVKaUO8oWlEg9SpmuZYv5YQSrWUhiXTLLQXU7Os+tJREZsJb6oG1nKO kZ11g/1r7ap6Hbs4Nr4T3OcSurWS7qvRaZFhXKGJEQ/2nIbXt12lT6MEwBV6niZdIHotcd oAw3moCMw9ffsV+uuES4nbYwO2ihrf+Ty/TepPe0/BF11nRGZ0JU1Tyi+4ujRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch 2021Q4 has been updated by rhurlin: URL: https://cgit.FreeBSD.org/ports/commit/?id=75007752abec044026edbb53aa0742cc47b49a89 commit 75007752abec044026edbb53aa0742cc47b49a89 Author: Dimitry Andric AuthorDate: 2021-11-23 17:08:01 +0000 Commit: Rainer Hurling CommitDate: 2021-11-23 19:32:31 +0000 graphics/qgis: Fix on CURRENT after llvm13 intro Right after replacing llvm12 with llvm13 in base (commits b61bce17f346d79cecfd8f195a64b10f77be43b1 to 397a8ba05313cc3815d219c9d1b2de1372fcb561) graphics/qgis was broken on 14.0-CURRENT with /usr/ports/graphics/qgis/work/QGIS-final-3_22_1/src/core/providers/ogr/qgsogrproviderutils.cpp:2595:34: error: no matching constructor for initialization of 'QgsOgrDatasetSharedPtr' (aka 'shared_ptr') QgsOgrDatasetSharedPtr dsRet = QgsOgrDatasetSharedPtr( new QgsOgrDataset(), QgsOgrProviderUtils::releaseDataset ); Thanks to dim@ for the analysis and solution. Much appreciated! PR: 259967 --- ...tch-src_core_providers_ogr_qgsogrproviderutils.cpp | 19 +++++++++++++++++++ ...patch-src_core_providers_ogr_qgsogrproviderutils.h | 11 +++++++++++ 2 files changed, 30 insertions(+) diff --git a/graphics/qgis/files/patch-src_core_providers_ogr_qgsogrproviderutils.cpp b/graphics/qgis/files/patch-src_core_providers_ogr_qgsogrproviderutils.cpp new file mode 100644 index 000000000000..92563ca24ac9 --- /dev/null +++ b/graphics/qgis/files/patch-src_core_providers_ogr_qgsogrproviderutils.cpp @@ -0,0 +1,19 @@ +--- src/core/providers/ogr/qgsogrproviderutils.cpp.orig 2021-11-19 12:08:37 UTC ++++ src/core/providers/ogr/qgsogrproviderutils.cpp +@@ -2311,7 +2311,7 @@ void QgsOgrProviderUtils::release( QgsOgrLayer *&layer + } + + +-void QgsOgrProviderUtils::releaseDataset( QgsOgrDataset *&ds ) ++void QgsOgrProviderUtils::releaseDataset( QgsOgrDataset *ds ) + { + if ( !ds ) + return; +@@ -2319,7 +2319,6 @@ void QgsOgrProviderUtils::releaseDataset( QgsOgrDatase + QMutexLocker locker( sGlobalMutex() ); + releaseInternal( ds->mIdent, ds->mDs, true ); + delete ds; +- ds = nullptr; + } + + bool QgsOgrProviderUtils::canDriverShareSameDatasetAmongLayers( const QString &driverName ) diff --git a/graphics/qgis/files/patch-src_core_providers_ogr_qgsogrproviderutils.h b/graphics/qgis/files/patch-src_core_providers_ogr_qgsogrproviderutils.h new file mode 100644 index 000000000000..472ef5ed8c07 --- /dev/null +++ b/graphics/qgis/files/patch-src_core_providers_ogr_qgsogrproviderutils.h @@ -0,0 +1,11 @@ +--- src/core/providers/ogr/qgsogrproviderutils.h.orig 2021-11-19 12:08:37 UTC ++++ src/core/providers/ogr/qgsogrproviderutils.h +@@ -216,7 +216,7 @@ class CORE_EXPORT QgsOgrProviderUtils + static void release( QgsOgrLayer *&layer ); + + //! Release a QgsOgrDataset* +- static void releaseDataset( QgsOgrDataset *&ds ); ++ static void releaseDataset( QgsOgrDataset *ds ); + + //! Make sure that the existing pool of opened datasets on dsName is not accessible for new getLayer() attempts + static void invalidateCachedDatasets( const QString &dsName );