From owner-svn-src-head@freebsd.org  Mon May 23 20:47:19 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 29281B47940;
 Mon, 23 May 2016 20:47:19 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id D8CC4186D;
 Mon, 23 May 2016 20:47:17 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA13134;
 Mon, 23 May 2016 23:47:10 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1b4wko-0002ya-4p; Mon, 23 May 2016 23:47:10 +0300
Subject: Re: svn commit: r300372 - in head/sys: kern sys
To: John Baldwin <jhb@FreeBSD.org>
References: <201605211451.u4LEpopu074806@repo.freebsd.org>
 <8562415.t0UfIz1aLk@ralph.baldwin.cx>
Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-head@FreeBSD.org
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <c0e1ee40-32de-48c4-363c-264801801bd1@FreeBSD.org>
Date: Mon, 23 May 2016 23:46:14 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <8562415.t0UfIz1aLk@ralph.baldwin.cx>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 May 2016 20:47:19 -0000


I don't know, I was just a proxy.
Kip is the author.

On 23/05/2016 21:43, John Baldwin wrote:
> On Saturday, May 21, 2016 02:51:50 PM Andriy Gapon wrote:
>> Author: avg
>> Date: Sat May 21 14:51:49 2016
>> New Revision: 300372
>> URL: https://svnweb.freebsd.org/changeset/base/300372
>>
>> Log:
>>   fix loss of taskqueue wakeups (introduced in r300113)
>>   
>>   Submitted by:	kmacy
>>   Tested by:	dchagin
>>
>> Modified: head/sys/sys/taskqueue.h
>> ==============================================================================
>> --- head/sys/sys/taskqueue.h	Sat May 21 11:40:41 2016	(r300371)
>> +++ head/sys/sys/taskqueue.h	Sat May 21 14:51:49 2016	(r300372)
>> @@ -114,7 +113,6 @@ void	taskqueue_thread_enqueue(void *cont
>>   */
>>  #define TASK_INIT(task, priority, func, context) do {	\
>>  	(task)->ta_pending = 0;				\
>> -	(task)->ta_flags = 0;				\
>>  	(task)->ta_priority = (priority);		\
>>  	(task)->ta_func = (func);			\
>>  	(task)->ta_context = (context);			\
>> @@ -224,7 +222,6 @@ int	taskqgroup_adjust(struct taskqgroup 
>>  
>>  #define GTASK_INIT(task, priority, func, context) do {	\
>>  	(task)->ta_pending = 0;				\
>> -	(task)->ta_flags = TASK_SKIP_WAKEUP;		\
>>  	(task)->ta_priority = (priority);		\
>>  	(task)->ta_func = (func);			\
>>  	(task)->ta_context = (context);			\
> 
> Do we still need GTASK_INIT() now or can relevant tasks now use
> TASK_INIT instead and GTASK_INIT be retired?
> 


-- 
Andriy Gapon