Date: Mon, 23 May 2016 23:46:14 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r300372 - in head/sys: kern sys Message-ID: <c0e1ee40-32de-48c4-363c-264801801bd1@FreeBSD.org> In-Reply-To: <8562415.t0UfIz1aLk@ralph.baldwin.cx> References: <201605211451.u4LEpopu074806@repo.freebsd.org> <8562415.t0UfIz1aLk@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
I don't know, I was just a proxy. Kip is the author. On 23/05/2016 21:43, John Baldwin wrote: > On Saturday, May 21, 2016 02:51:50 PM Andriy Gapon wrote: >> Author: avg >> Date: Sat May 21 14:51:49 2016 >> New Revision: 300372 >> URL: https://svnweb.freebsd.org/changeset/base/300372 >> >> Log: >> fix loss of taskqueue wakeups (introduced in r300113) >> >> Submitted by: kmacy >> Tested by: dchagin >> >> Modified: head/sys/sys/taskqueue.h >> ============================================================================== >> --- head/sys/sys/taskqueue.h Sat May 21 11:40:41 2016 (r300371) >> +++ head/sys/sys/taskqueue.h Sat May 21 14:51:49 2016 (r300372) >> @@ -114,7 +113,6 @@ void taskqueue_thread_enqueue(void *cont >> */ >> #define TASK_INIT(task, priority, func, context) do { \ >> (task)->ta_pending = 0; \ >> - (task)->ta_flags = 0; \ >> (task)->ta_priority = (priority); \ >> (task)->ta_func = (func); \ >> (task)->ta_context = (context); \ >> @@ -224,7 +222,6 @@ int taskqgroup_adjust(struct taskqgroup >> >> #define GTASK_INIT(task, priority, func, context) do { \ >> (task)->ta_pending = 0; \ >> - (task)->ta_flags = TASK_SKIP_WAKEUP; \ >> (task)->ta_priority = (priority); \ >> (task)->ta_func = (func); \ >> (task)->ta_context = (context); \ > > Do we still need GTASK_INIT() now or can relevant tasks now use > TASK_INIT instead and GTASK_INIT be retired? > -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c0e1ee40-32de-48c4-363c-264801801bd1>