From owner-svn-src-head@FreeBSD.ORG Thu Feb 3 13:09:22 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DE82106564A; Thu, 3 Feb 2011 13:09:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 6C9AA8FC0A; Thu, 3 Feb 2011 13:09:22 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p13D9MvK046349; Thu, 3 Feb 2011 13:09:22 GMT (envelope-from jhb@svn.freebsd.org) Received: (from jhb@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p13D9MfK046347; Thu, 3 Feb 2011 13:09:22 GMT (envelope-from jhb@svn.freebsd.org) Message-Id: <201102031309.p13D9MfK046347@svn.freebsd.org> From: John Baldwin Date: Thu, 3 Feb 2011 13:09:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r218221 - head/sys/x86/x86 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2011 13:09:22 -0000 Author: jhb Date: Thu Feb 3 13:09:22 2011 New Revision: 218221 URL: http://svn.freebsd.org/changeset/base/218221 Log: Use a dedicated taskqueue with a thread that runs at a software-interrupt priority for the periodic polling of the machine check registers. Modified: head/sys/x86/x86/mca.c Modified: head/sys/x86/x86/mca.c ============================================================================== --- head/sys/x86/x86/mca.c Thu Feb 3 12:19:07 2011 (r218220) +++ head/sys/x86/x86/mca.c Thu Feb 3 13:09:22 2011 (r218221) @@ -105,6 +105,7 @@ SYSCTL_INT(_hw_mca, OID_AUTO, erratum383 static STAILQ_HEAD(, mca_internal) mca_records; static struct callout mca_timer; static int mca_ticks = 3600; /* Check hourly by default. */ +static struct taskqueue *mca_tq; static struct task mca_task; static struct mtx mca_lock; @@ -606,7 +607,7 @@ static void mca_periodic_scan(void *arg) { - taskqueue_enqueue(taskqueue_thread, &mca_task); + taskqueue_enqueue(mca_tq, &mca_task); callout_reset(&mca_timer, mca_ticks * hz, mca_periodic_scan, NULL); } @@ -620,7 +621,7 @@ sysctl_mca_scan(SYSCTL_HANDLER_ARGS) if (error) return (error); if (i) - taskqueue_enqueue(taskqueue_thread, &mca_task); + taskqueue_enqueue(mca_tq, &mca_task); return (0); } @@ -631,6 +632,9 @@ mca_startup(void *dummy) if (!mca_enabled || !(cpu_feature & CPUID_MCA)) return; + mca_tq = taskqueue_create("mca", M_WAITOK, taskqueue_thread_enqueue, + &mca_tq); + taskqueue_start_threads(&mca_tq, 1, PI_SWI(SWI_TQ), "mca taskq"); callout_reset(&mca_timer, mca_ticks * hz, mca_periodic_scan, NULL); } @@ -670,7 +674,7 @@ mca_setup(uint64_t mcg_cap) mtx_init(&mca_lock, "mca", NULL, MTX_SPIN); STAILQ_INIT(&mca_records); - TASK_INIT(&mca_task, 0x8000, mca_scan_cpus, NULL); + TASK_INIT(&mca_task, 0, mca_scan_cpus, NULL); callout_init(&mca_timer, CALLOUT_MPSAFE); SYSCTL_ADD_INT(NULL, SYSCTL_STATIC_CHILDREN(_hw_mca), OID_AUTO, "count", CTLFLAG_RD, &mca_count, 0, "Record count");