Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Feb 2012 21:10:16 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-sparc64@FreeBSD.org
Subject:   Re: sparc64/164226: commit references a PR
Message-ID:  <201202012110.q11LAG7h088051@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR sparc64/164226; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: sparc64/164226: commit references a PR
Date: Wed,  1 Feb 2012 21:08:57 +0000 (UTC)

 Author: marius
 Date: Wed Feb  1 21:08:35 2012
 New Revision: 230881
 URL: http://svn.freebsd.org/changeset/base/230881
 
 Log:
   MFC: r230627
   
   Using ATA_CAM along with ATAPI DMA causes data corruption with ALI_NEW
   and CMD controllers for reasons unknown so disable it.
   
   PR:	164226
 
 Modified:
   stable/8/sys/dev/ata/chipsets/ata-acerlabs.c
   stable/8/sys/dev/ata/chipsets/ata-siliconimage.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/e1000/   (props changed)
 
 Modified: stable/8/sys/dev/ata/chipsets/ata-acerlabs.c
 ==============================================================================
 --- stable/8/sys/dev/ata/chipsets/ata-acerlabs.c	Wed Feb  1 21:08:33 2012	(r230880)
 +++ stable/8/sys/dev/ata/chipsets/ata-acerlabs.c	Wed Feb  1 21:08:35 2012	(r230881)
 @@ -213,6 +213,10 @@ ata_ali_ch_attach(device_t dev)
  	if (ch->dma.max_iosize > 256 * 512)
  		ch->dma.max_iosize = 256 * 512;
      }
 +#ifdef ATA_CAM
 +	if (ctlr->chip->cfg2 & ALI_NEW)
 +		ch->flags |= ATA_NO_ATAPI_DMA;
 +#endif
  
      return 0;
  }
 
 Modified: stable/8/sys/dev/ata/chipsets/ata-siliconimage.c
 ==============================================================================
 --- stable/8/sys/dev/ata/chipsets/ata-siliconimage.c	Wed Feb  1 21:08:33 2012	(r230880)
 +++ stable/8/sys/dev/ata/chipsets/ata-siliconimage.c	Wed Feb  1 21:08:35 2012	(r230881)
 @@ -240,6 +240,10 @@ ata_cmd_ch_attach(device_t dev)
      if (ctlr->chip->cfg2 & SII_INTR)
  	ch->hw.status = ata_cmd_status;
  
 +#ifdef ATA_CAM
 +	ch->flags |= ATA_NO_ATAPI_DMA;
 +#endif
 +
      return 0;
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201202012110.q11LAG7h088051>