From owner-cvs-user  Fri Aug 25 16:47:01 1995
Return-Path: cvs-user-owner
Received: (from majordom@localhost)
          by freefall.FreeBSD.org (8.6.11/8.6.6) id QAA09993
          for cvs-user-outgoing; Fri, 25 Aug 1995 16:47:01 -0700
Received: from localhost (localhost [127.0.0.1])
          by freefall.FreeBSD.org (8.6.11/8.6.6) with SMTP id QAA09986
          ; Fri, 25 Aug 1995 16:46:56 -0700
Message-Id: <199508252346.QAA09986@freefall.FreeBSD.org>
X-Authentication-Warning: freefall.FreeBSD.org: Host localhost didn't use HELO protocol
To: Mark Murray <markm@freefall.FreeBSD.org>
cc: CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org
Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c 
In-reply-to: Your message of "Fri, 25 Aug 95 15:52:33 PDT."
             <199508252252.PAA07586@freefall.FreeBSD.org> 
Date: Fri, 25 Aug 1995 16:46:55 -0700
From: "Justin T. Gibbs" <gibbs@freefall.FreeBSD.org>
Sender: cvs-user-owner@FreeBSD.org
Precedence: bulk

>markm       95/08/25 15:52:32
>
>  Modified:    eBones    Copyright.MIT Copyright.SIPB Makefile Makefile.inc
>			  ...
>  Log:
>  Start the eBones cleanup ball rolling.
>  These are the start of a lot of work to clean up the FreeBSD eBones code.
>  these changes include, but are not limited to:
>  - Create prototypes for all the library routines
>  - Make all the libraries compile clean with -Wall set
>  - Fix numerous small bugs shown up in the above process
>  - Prepare the code for libdes's removal to secure/
>  - add register, registerd and make_keypair to the make
>  Lots more will follow in days to come.
>  
>  OK'ed by: rgrimes

Was there a reason for changing all function declarations from:

static send_recv(pkt,rpkt,f,_to,addrs)
    KTEXT pkt;
    KTEXT rpkt;
    int f;
    struct sockaddr_in *_to;
    struct hostent *addrs;
{

to:

static int send_recv(KTEXT pkt, KTEXT rpkt, int f, struct sockaddr_in *_to,
    struct hostent *addrs)
{

I don't view this as a cleanup at all.  It makes unnecessary conflicts with
the original code and makes it more difficult to incomperate patches from
outside sources.

:-(

--
Justin T. Gibbs
===========================================
  Software Developer - Walnut Creek CDROM
  FreeBSD: Turning PCs into workstations
===========================================