From owner-p4-projects@FreeBSD.ORG  Thu Jul  2 09:12:29 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 399B91065672; Thu,  2 Jul 2009 09:12:29 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ED7F1106566C
	for <perforce@FreeBSD.org>; Thu,  2 Jul 2009 09:12:28 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id C12648FC1D
	for <perforce@FreeBSD.org>; Thu,  2 Jul 2009 09:12:28 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n629CS0F065196
	for <perforce@FreeBSD.org>; Thu, 2 Jul 2009 09:12:28 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n629CSJ3065194
	for perforce@freebsd.org; Thu, 2 Jul 2009 09:12:28 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Date: Thu, 2 Jul 2009 09:12:28 GMT
Message-Id: <200907020912.n629CSJ3065194@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zhaoshuai@FreeBSD.org using -f
From: Zhao Shuai <zhaoshuai@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 165534 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2009 09:12:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=165534

Change 165534 by zhaoshuai@zhaoshuai on 2009/07/02 09:12:20

	don't poll/select on a closed file descriptor.

Affected files ...

.. //depot/projects/soc2009/fifo/fifo_test/regression/fifo_io/fifo_io.c#3 edit

Differences ...

==== //depot/projects/soc2009/fifo/fifo_test/regression/fifo_io/fifo_io.c#3 (text+ko) ====

@@ -1416,22 +1416,13 @@
 	}
 
 	/* 
-	 * close the reader, which should cause 
-	 * - reader_fd unreadable, unwritable, not exceptional
-	 * - writer_fd unreadable, unwritable, not exceptional
+	 * close the reader, which should cause writer_fd unreadable, 
+	 * writable, not exceptional
 	 */
 	close(reader_fd);
 
-	/*
-	if (assert_status(reader_fd, kqueue_fd, NOT_READABLE, NOT_WRITABLE,
-	    NOT_EXCEPTION, __func__, "close_reader", "reader_fd") < 0) {
-		cleanfifo2("testfifo", writer_fd, kqueue_fd);
-		exit(-1);
-	}
-	*/
-
-	if (assert_status(writer_fd, kqueue_fd, READABLE, WRITABLE,
-	    EXCEPTION, __func__, "close_reader", "writer_fd") < 0) {
+	if (assert_status(writer_fd, kqueue_fd, NOT_READABLE, WRITABLE,
+	    NOT_EXCEPTION, __func__, "close_reader", "writer_fd") < 0) {
 		cleanfifo2("testfifo", writer_fd, kqueue_fd);
 		exit(-1);
 	}
@@ -1473,26 +1464,17 @@
 	}
 
 	/* 
-	 * close the writer, which should cause 
-	 * - reader_fd readable, unwritable, exceptional
-	 * - writer_fd unreadable, unwritable, not exceptional
+	 * close the writer, which should cause reader_fd readable, 
+	 * unwritable, not exceptional
 	 */
 	close(writer_fd);
 
-	if (assert_status(reader_fd, kqueue_fd, NOT_READABLE, NOT_WRITABLE,
+	if (assert_status(reader_fd, kqueue_fd, READABLE, NOT_WRITABLE,
 	    NOT_EXCEPTION, __func__, "close_writer", "reader_fd") < 0) {
 		cleanfifo2("testfifo", reader_fd, kqueue_fd);
 		exit(-1);
 	}
 
-	/*
-	if (assert_status(writer_fd, kqueue_fd, NOT_READABLE, NOT_WRITABLE,
-	    NOT_EXCEPTION, __func__, "close_writer", "writer_fd") < 0) {
-		cleanfifo2("testfifo", reader_fd, kqueue_fd);
-		exit(-1);
-	}
-	*/
-
 	cleanfifo2("testfifo", reader_fd, kqueue_fd);
 }