From owner-freebsd-fs@FreeBSD.ORG Sat Dec 13 18:46:11 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 060AF1065673 for ; Sat, 13 Dec 2008 18:46:11 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from emh01.mail.saunalahti.fi (emh01.mail.saunalahti.fi [62.142.5.107]) by mx1.freebsd.org (Postfix) with ESMTP id B56428FC0C for ; Sat, 13 Dec 2008 18:46:10 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from saunalahti-vams (vs3-11.mail.saunalahti.fi [62.142.5.95]) by emh01-2.mail.saunalahti.fi (Postfix) with SMTP id A1DF51A9E9; Sat, 13 Dec 2008 20:31:01 +0200 (EET) Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by vs3-11.mail.saunalahti.fi ([62.142.5.95]) with SMTP (gateway) id A0046B9EC27; Sat, 13 Dec 2008 20:31:01 +0200 Received: from a91-153-125-115.elisa-laajakaista.fi (a91-153-125-115.elisa-laajakaista.fi [91.153.125.115]) by emh03.mail.saunalahti.fi (Postfix) with SMTP id 503B5158A6F; Sat, 13 Dec 2008 20:30:59 +0200 (EET) Date: Sat, 13 Dec 2008 20:30:59 +0200 From: Jaakko Heinonen To: "Rick C. Petty" Message-ID: <20081213183058.GA20992@a91-153-125-115.elisa-laajakaista.fi> References: <20081213173902.GA96883@keira.kiwi-computer.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081213173902.GA96883@keira.kiwi-computer.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Antivirus: VAMS Cc: freebsd-fs@freebsd.org Subject: Re: UFS label limitations X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Dec 2008 18:46:11 -0000 Hi, On 2008-12-13, Rick C. Petty wrote: > I applied the attached (inline) patch and have had no troubles creating, > editing, or mounting via UFS labels. The patch allows you to create > labels with any characters except '/' (for obvious reasons) and should > work with most locales (with the tiny exception that multibyte characters > which use 0x2F in subsequent bytes should be rejected, since geom_label > is locale-agnostic). geom_label has problems with other characters too. The problem is that it doesn't encode characters for XML output properly. See these PRs: http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/104389 http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/120044 This already causes problems with file systems which allow non-ASCII label names. IMO the problem should be addressed before extending allowed characters in UFS labels. -- Jaakko