Date: Fri, 1 Jan 2016 04:57:40 +0100 From: Oliver Pinter <oliver.pinter@hardenedbsd.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: John Baldwin <john@baldwin.cx>, "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-stable-10@freebsd.org" <svn-src-stable-10@freebsd.org>, Garrett Cooper <ngie@freebsd.org> Subject: Re: svn commit: r292975 - stable/10/sys/dev/pci Message-ID: <CAPQ4ffsjYFQH8ZX0=Xbc84V_%2BBZ0_3QX7q-9Mzb1Nfn9b21Tdw@mail.gmail.com> In-Reply-To: <633EF3EE-0899-45A1-B12C-CC2290A1FA29@gmail.com> References: <201512310355.tBV3t2VG040656@repo.freebsd.org> <2893860.oDiG4KQizb@ralph.baldwin.cx> <633EF3EE-0899-45A1-B12C-CC2290A1FA29@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, December 31, 2015, NGie Cooper <yaneurabeya@gmail.com> wrote: > > > On Dec 31, 2015, at 08:42, John Baldwin <john@baldwin.cx <javascript:;>= > > wrote: > > > > On Thursday, December 31, 2015 03:55:02 AM Garrett Cooper wrote: > >> Author: ngie > >> Date: Thu Dec 31 03:55:02 2015 > >> New Revision: 292975 > >> URL: https://svnweb.freebsd.org/changeset/base/292975 > >> > >> Log: > >> MFC r278860: > >> r278860 (by jmg): > >> > >> remove NULL check as M_WAITOK will not return NULL > >> > >> Reviewed by: jhb > >> Sponsored by: FreeBSD Foundation > > > > Including the metadata from the HEAD commit in the MFC can be > misleading, and > > I think it is best ommitted. For example, I did not review this MFC (a= nd > > reviewing MFC's in their own right matters since they may require > additional > > work than commits to HEAD due to ABI concerns), nor did the Foundation > sponsor > > the MFC. Rather, I think MFCs should only specify metadata related to > the > > actual merge itself. > > Agreed. I=E2=80=99ve changed my mfc_log script to skip over some more unn= ecessary > svn log metadata: > https://github.com/yaneurabeya/scratch/commit/4f897efb96f96f951ff3909857f= 67e63b24b733a > . > Thanks :)! > -NGie It would be nice to commit this script under tools directory. > _______________________________________________ > svn-src-stable-10@freebsd.org <javascript:;> mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10 > To unsubscribe, send any mail to " > svn-src-stable-10-unsubscribe@freebsd.org <javascript:;>"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffsjYFQH8ZX0=Xbc84V_%2BBZ0_3QX7q-9Mzb1Nfn9b21Tdw>