From owner-freebsd-hackers@FreeBSD.ORG  Thu Jul 12 19:11:57 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DD44F1065786
	for <freebsd-hackers@FreeBSD.org>; Thu, 12 Jul 2012 19:11:57 +0000 (UTC)
	(envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E23E8FC12
	for <freebsd-hackers@FreeBSD.org>; Thu, 12 Jul 2012 19:11:56 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA25825;
	Thu, 12 Jul 2012 22:11:46 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1SpOni-000726-H8; Thu, 12 Jul 2012 22:11:46 +0300
Message-ID: <4FFF2171.1030800@FreeBSD.org>
Date: Thu, 12 Jul 2012 22:11:45 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:13.0) Gecko/20120620 Thunderbird/13.0.1
MIME-Version: 1.0
To: Fabian Keil <freebsd-listen@fabiankeil.de>
References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com>
	<4FFB4770.7050209@FreeBSD.org>
	<20120710154128.192eb8d6@fabiankeil.de>
	<1341939155.2573.8.camel@powernoodle.corp.yahoo.com>
	<20120710205702.5e57168b@fabiankeil.de>
	<4FFC8479.9080608@FreeBSD.org>
	<20120711122935.1382e76d@fabiankeil.de>
	<alpine.GSO.1.10.1207112007240.18441@multics.mit.edu>
	<20120712201741.34573af4@fabiankeil.de>
In-Reply-To: <20120712201741.34573af4@fabiankeil.de>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@FreeBSD.org, Benjamin Kaduk <kaduk@MIT.EDU>,
	Sean Bruno <seanbru@yahoo-inc.com>
Subject: Re: dtraceall.ko with old nfsclient
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2012 19:11:58 -0000

on 12/07/2012 21:17 Fabian Keil said the following:
> Benjamin Kaduk <kaduk@MIT.EDU> wrote:
> 
>> On Wed, 11 Jul 2012, Fabian Keil wrote:
>> 
>>> I'm using the following modification of Sean's patch:
> 
> This way it seems to work as expected:
> 
> diff --git a/sys/modules/dtrace/dtraceall/Makefile
> b/sys/modules/dtrace/dtraceall/Makefile index 456efd1..628583b 100644 ---
> a/sys/modules/dtrace/dtraceall/Makefile +++
> b/sys/modules/dtrace/dtraceall/Makefile @@ -1,7 +1,7 @@ # $FreeBSD:
> src/sys/modules/dtrace/dtraceall/Makefile,v 1.3 2011/04/09 09:07:31 uqs Exp
> $
> 
> KMOD=          dtraceall -SRCS=          dtraceall.c opt_compat.h +SRCS=
> dtraceall.c opt_compat.h opt_nfs.h
> 
> CFLAGS+=       -I${.CURDIR}/../../..
> 

If you do cd sys/modules/dtrace/dtraceall && make [obj depend] all, does it
compile OK with the above change?
I am hinting at the case where KERNBUILDDIR is not set.
This is not the proper way of building modules, but traditionally we keep it
working.

-- 
Andriy Gapon